From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754308AbYJEDO0 (ORCPT ); Sat, 4 Oct 2008 23:14:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753072AbYJEDOT (ORCPT ); Sat, 4 Oct 2008 23:14:19 -0400 Received: from ns.suse.de ([195.135.220.2]:45473 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753040AbYJEDOT (ORCPT ); Sat, 4 Oct 2008 23:14:19 -0400 Date: Sat, 4 Oct 2008 19:54:01 -0700 From: Greg KH To: Stefan Lippers-Hollmann Cc: linux-kernel@vger.kernel.org, tj@kernel.org, jgarzik@redhat.com, pchen@nvidia.com, stable@kernel.org Subject: Re: patch sata_nv-disable-hardreset-for-generic.patch added to 2.6.26-stable tree Message-ID: <20081005025401.GA22549@suse.de> References: <20081001234424.C72C114543E5@imap.suse.de> <200810041827.04721.s.L-H@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200810041827.04721.s.L-H@gmx.de> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 04, 2008 at 06:27:03PM +0200, Stefan Lippers-Hollmann wrote: > Hi > > On Donnerstag, 2. Oktober 2008, gregkh@suse.de wrote: > > > > This is a note to let you know that we have just queued up the patch titled > > > > Subject: sata_nv: disable hardreset for generic > > > > to the 2.6.26-stable tree. Its filename is > > > > sata_nv-disable-hardreset-for-generic.patch > > > > A git repo of this tree can be found at > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > > > From 2fd673ecf0378ddeeeb87b3605e50212e0c0ddc6 Mon Sep 17 00:00:00 2001 > > From: Tejun Heo > > Date: Fri, 29 Aug 2008 16:13:12 +0200 > > Subject: sata_nv: disable hardreset for generic > > > > From: Tejun Heo > > > > commit 2fd673ecf0378ddeeeb87b3605e50212e0c0ddc6 upstream > > > > of them being unifying probing, hotplug and EH reset paths uniform. > > Previously, broken hardreset could go unnoticed as it wasn't used > > during probing but when something goes wrong or after hotplug the > > problem will surface and bite hard. > > > > OSDL bug 11195 reports that sata_nv generic flavor falls into this > > category. Hardreset itself succeeds but PHY stays offline after > > hardreset. I tried longer debounce timing but the result was the > > same. > > > > http://bugzilla.kernel.org/show_bug.cgi?id=11195 > > > > So, it seems we'll have to drop hardreset from the generic flavor. > > > > Signed-off-by: Tejun Heo > > Cc: Peer Chen > > Signed-off-by: Jeff Garzik > > Signed-off-by: Greg Kroah-Hartman > > On 2.6.26.5 + the pending stable queue applied, this patch results in lots > of noise in my syslog (full gzipped dmesg with and without this patch > attached): This patch has been removed from the stable queue, so it shouldn't be an issue anymore, right? thanks, greg k-h