Re: [PATCH 36/76] tty: Make get_current_tty use a kref

Alan Cox
2008-10-06T10:57:17Z

On Mon, Oct 06, 2008 at 12:35:40PM +0200, Louis Rilling wrote:
> > tty = get_current_tty();
> > if (!tty || tty->driver->major != IBM_TTY3270_MAJOR) {
> > - mutex_unlock(&tty_mutex);
> > + tty_kref_put(tty);
>
> Should'nt mutex_unlock() be kept?

Yes.. although it gets fixed later but I will fix that as it will keep the
code bisectable.