From: Ingo Molnar <mingo@elte.hu>
To: Huang Ying <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH -mm -v3] Separate atomic_t declaration from asm/atomic.h into asm/atomic_def.h
Date: Mon, 6 Oct 2008 07:00:22 +0200 [thread overview]
Message-ID: <20081006050022.GA2186@elte.hu> (raw)
In-Reply-To: <1223263964.5872.20.camel@yhuang-dev.sh.intel.com>
* Huang Ying <ying.huang@intel.com> wrote:
> From: Huang Ying <ying.huang@intel.com>
>
> asm/atomic.h contains both declaration and implementation of atomic_t. So
> there are some implementation related files included in asm/atomic.h. And
> atomic_t is a typedef. Combination of above makes it impossible to use
> atomic_t in files included by atomic.h. Such as atomic_t can not be used
> in linux/kernel.h on i386, because it is included by asm/atomic.h.
>
> It is reasonable to separate declaration from implementation. So a new
> file atomic_def.h is added for every architecture to accommodate the
> declaration of atomic_t.
>
> Includes fixes from Andrew Moton.
>
> Signed-off-by: Huang Ying <ying.huang@intel.com>
> ---
>
> include/asm-x86/atomic_32.h | 10 +---------
> include/asm-x86/atomic_64.h | 10 +---------
> include/asm-x86/atomic_def.h | 13 +++++++++++++
nice cleanup!
One small request: could you please use the standard naming convention
please and rename it to atomic_types.h?
That moves it in line with existing data type files: kvm_types.h,
mm_types.h, posix_types.h, spinlock_types.h, amd_iommu_types.h,
kmap_types.h, etc.
Easiest is to do it via:
sed -i 's/atomic_def.h/atomic_types.h/g' patches/separate-atomic.patch
Reviewed-by: Ingo Molnar <mingo@elte.hu>
Thanks,
Ingo
next prev parent reply other threads:[~2008-10-06 5:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 3:32 [PATCH -mm -v3] Separate atomic_t declaration from asm/atomic.h into asm/atomic_def.h Huang Ying
2008-10-06 5:00 ` Ingo Molnar [this message]
2008-10-06 8:48 ` Geert Uytterhoeven
2008-10-07 1:09 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081006050022.GA2186@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox