From: Pavel Machek <pavel@suse.cz>
To: Greg KH <greg@kroah.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Hannes Reinecke <hare@suse.de>, "Rafael J. Wysocki" <rjw@sisk.pl>,
Kay Sievers <kay.sievers@vrfy.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jiri Slaby <jirislaby@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] PM: use pm_op methods for device types
Date: Mon, 6 Oct 2008 17:11:27 +0200 [thread overview]
Message-ID: <20081006151127.GC1380@ucw.cz> (raw)
In-Reply-To: <20080926175922.GA767@kroah.com>
> > Okay, I was confused too. Looking more closely, it's apparent that
> > mainline is okay and the problem was introduced by Hannes Reinecke's
> >
> > driver-core-remove-suspend-resume-callbacks-for-device-type.patch
> >
> > which states that the suspend/resume callbacks in struct device_type
> > are unused. It may be true that the legacy suspend/resume methods are
> > unused, but the new pm_ops methods definitely are used.
> >
> > Therefore part or all of Hannes patch should be reverted. And the
> > mainline is okay as it stands.
>
> Ah, ick.
>
> Hannes, care to respin this patch based on this information?
I guess Hannes patch shoud simply be dropped....
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2008-10-07 13:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 14:00 hda_intel (sigmatel) defunct in mmotm 2008-09-13-03-09 Jiri Slaby
2008-09-15 14:16 ` Matthew Ranostay
2008-09-16 14:43 ` Matthew Ranostay
2008-09-17 8:58 ` Jiri Slaby
2008-09-17 14:09 ` Matthew Ranostay
2008-09-24 9:42 ` Jiri Slaby
2008-09-17 16:46 ` suspend (uhci_hcd) " Jiri Slaby
2008-09-18 21:14 ` Alan Stern
2008-09-24 10:55 ` Jiri Slaby
2008-09-24 14:49 ` Alan Stern
2008-09-24 16:04 ` Jiri Slaby
2008-09-24 16:38 ` Alan Stern
2008-09-24 18:14 ` Greg KH
2008-09-24 18:19 ` Jiri Slaby
2008-09-24 18:54 ` Jiri Slaby
2008-09-24 21:29 ` Alan Stern
2008-09-25 20:51 ` Jiri Slaby
2008-09-25 21:07 ` [PATCH] PM: use pm_op methods for device types Alan Stern
2008-09-25 21:27 ` Rafael J. Wysocki
2008-09-25 22:06 ` Greg KH
2008-09-26 13:56 ` Alan Stern
2008-09-26 17:59 ` Greg KH
2008-10-06 15:11 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081006151127.GC1380@ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=hare@suse.de \
--cc=jirislaby@gmail.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox