From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754677AbYJGNGy (ORCPT ); Tue, 7 Oct 2008 09:06:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753378AbYJGNGo (ORCPT ); Tue, 7 Oct 2008 09:06:44 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:56572 "EHLO UNKNOWN" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753384AbYJGNGn (ORCPT ); Tue, 7 Oct 2008 09:06:43 -0400 Date: Mon, 6 Oct 2008 17:11:27 +0200 From: Pavel Machek To: Greg KH Cc: Alan Stern , Hannes Reinecke , "Rafael J. Wysocki" , Kay Sievers , Andrew Morton , Jiri Slaby , Linux Kernel Mailing List , Linux-pm mailing list , USB list Subject: Re: [PATCH] PM: use pm_op methods for device types Message-ID: <20081006151127.GC1380@ucw.cz> References: <20080925220635.GA12175@kroah.com> <20080926175922.GA767@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080926175922.GA767@kroah.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Okay, I was confused too. Looking more closely, it's apparent that > > mainline is okay and the problem was introduced by Hannes Reinecke's > > > > driver-core-remove-suspend-resume-callbacks-for-device-type.patch > > > > which states that the suspend/resume callbacks in struct device_type > > are unused. It may be true that the legacy suspend/resume methods are > > unused, but the new pm_ops methods definitely are used. > > > > Therefore part or all of Hannes patch should be reverted. And the > > mainline is okay as it stands. > > Ah, ick. > > Hannes, care to respin this patch based on this information? I guess Hannes patch shoud simply be dropped.... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html