Re: [PATCH 3/3] Convert the UDP hash lock to RCU

Christoph Lameter
2008-10-07T14:54:26Z

Paul E. McKenney wrote:

> But care is required -- SLAB_DESTROY_BY_RCU permits objects to be freed
> and reallocated while a reader holds a reference. The only guarantee is
> that the -type- of the data structure will not change while a reader holds
> a reference. With something like UDP, this might well be sufficient.

Right so after the hash lookup operation you are not assured that the object
has not been freed or even reallocated for a different purpose. So after
finding the pointer to the object two things need to happen (under rcu_lock):

1. Verify that the object is still in use
2. Verify that the object is matching the hash

If not then the operation needs to be redone because we have a stale hash pointer.