public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: fangxiaozhi 00110321 <huananhu@huawei.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	zihan@huawei.com, zhangqianchun@huawei.com
Subject: Re: PATCH 10/4]linux-usb: To support more Huawei data card product IDs, fix kernel 2.6.27-rc7
Date: Tue, 7 Oct 2008 20:21:39 -0700	[thread overview]
Message-ID: <20081008032139.GA14931@kroah.com> (raw)
In-Reply-To: <faf7b1bd45d66.45d66faf7b1bd@huawei.com>

On Wed, Oct 08, 2008 at 09:31:35AM +0800, fangxiaozhi 00110321 wrote:
>   From: fangxiaozhi <huananhu@huawei.com>
>  
>  1. This patch is based on the kernel of 2.6.27-rc7 
>  2. In this patch, we want to do one thing: add more Huawei product IDs into the USB driver. Then it can support  more Huawei data card devices. So to declare the unusual device for new Huawei data card devices 
>  in unusual_devs.h and to declare more new product IDs in option.c.
>  3. To modify the data value and length in the function of 
>  usb_stor_huawei_e220_init in initializers.c
>    That's because based on the USB standard, while sending SET_FETURE_D to the device, it requires the corresponding data to be zero, and its sending length also must be zero.
>    In our old solution, it can be compatible with our WCDMA data card devices, but can not support our CDMA data card devices. 
>     But in this new solution, it can be compatible with all of our data card devices.
> 
>  Signed-off-by: fangxiaozhi <huananhu@huawei.com>
>  -------------------------------------------------------------------
> 
> diff -uprN -X linux-2.6.27-rc7-orig/Documentation/dontdiff linux-2.6.27-rc7-orig/drivers/usb/serial/option.c linux-2.6.27-rc7/drivers/usb/serial/option.c
> --- linux-2.6.27-rc7-orig/drivers/usb/serial/option.c 2008-09-22 06:29:55.000000000 +0800
> +++ linux-2.6.27-rc7/drivers/usb/serial/option.c 2008-09-24 12:00:14.000000000 +0800
> @@ -106,11 +106,20 @@ static int  option_send_setup(struct tty
>  #define HUAWEI_PRODUCT_E220                 0x1003
>  #define HUAWEI_PRODUCT_E220BIS                 0x1004
>  #define HUAWEI_PRODUCT_E1401                 0x1401
> +#define HUAWEI_PRODUCT_E1402                 0x1402

Hm, all of the tabs seem to have been converted to spaces in this patch,
and it does not apply at all.

Care to fix your email client settings and try again?

thanks,

greg k-h

  reply	other threads:[~2008-10-08  3:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-08  1:31 PATCH 10/4]linux-usb: To support more Huawei data card product IDs, fix kernel 2.6.27-rc7 fangxiaozhi 00110321
2008-10-08  3:21 ` Greg KH [this message]
2008-10-08  3:58   ` PATCH 10/4]linux-usb: To support more Huawei data card productIDs, " Franko Fang
2008-10-08 14:07 ` PATCH 10/4]linux-usb: To support more Huawei data card product IDs, " Alan Stern
  -- strict thread matches above, loose matches on Subject: below --
2008-09-24  2:07 [PATCH 10/4]linux-usb: To support more Huawei data card product IDs, fix kernel 2.6.26.5 fangxiaozhi 00110321
2008-09-24  6:08 ` PATCH 10/4]linux-usb: To support more Huawei data card product IDs, fix kernel 2.6.27-rc7 fangxiaozhi 00110321
2008-09-24 14:38   ` Alan Stern
2008-09-24 15:03   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081008032139.GA14931@kroah.com \
    --to=greg@kroah.com \
    --cc=huananhu@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=zhangqianchun@huawei.com \
    --cc=zihan@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox