Re: [PATCH] IDE-TAPE NULL terminate strings.

Mark de Wever
2008-09-21T20:29:41Z

On Mon, Sep 22, 2008 at 12:08:27AM +0400, Sergei Shtylyov wrote:
>>> diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
>>> index 1bce84b..fd87b43 100644
>>> --- a/drivers/ide/ide-tape.c
>>> +++ b/drivers/ide/ide-tape.c
>>> @@ -2354,6 +2354,10 @@ static void
>>> idetape_get_inquiry_results(ide_drive_t *drive)
>>> ide_fixstring(product_id, 18, 0);
>>> ide_fixstring(fw_rev, 6, 0);
>
> Hm, I see that every string variable declared there has 2 extra
> characters, and yet the author have managed to make a mistake... these
> extra chars don't seem needed.

Those extra characters made me believe the intention was setting the
NULL character, therefore I used that solution in my patch.

Regards,
Mark de Wever