From: Dave Jones <davej@redhat.com>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: fsl_upm compile failure.
Date: Wed, 8 Oct 2008 18:28:15 -0400 [thread overview]
Message-ID: <20081008222815.GA20542@redhat.com> (raw)
Hi Anton,
I tried reenabling CONFIG_MTD_NAND_FSL_UPM in the Fedora kernel
today (currently on 2.6.27-rc9-git1), and got the error below.
ERROR: "fsl_lbc_lock" [drivers/mtd/nand/fsl_upm.ko] undefined!
It seems that this isn't exported to modules.
diff below fixes this. (Not tested yet, the Fedora ppc
builders are a little slow).
Dave
---
CONFIG_MTD_NAND_FSL_UPM can be built modular, but needs to
use fsl_lbc_lock, which isn't currently exported.
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/arch/powerpc/sysdev/fsl_lbc.c b/arch/powerpc/sysdev/fsl_lbc.c
index 422c8fa..1c6c522 100644
--- a/arch/powerpc/sysdev/fsl_lbc.c
+++ b/arch/powerpc/sysdev/fsl_lbc.c
@@ -16,6 +16,7 @@
#include <asm/fsl_lbc.h>
spinlock_t fsl_lbc_lock = __SPIN_LOCK_UNLOCKED(fsl_lbc_lock);
+EXPORT_SYMBOL(fsl_lbc_lock);
struct fsl_lbc_regs __iomem *fsl_lbc_regs;
EXPORT_SYMBOL(fsl_lbc_regs);
next reply other threads:[~2008-10-08 22:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 22:28 Dave Jones [this message]
2008-10-08 23:02 ` fsl_upm compile failure Anton Vorontsov
2008-10-08 23:17 ` Anton Vorontsov
2008-10-08 23:33 ` Dave Jones
2008-10-09 0:32 ` [PATCH] powerpc: fix fsl_upm nand driver modular build Anton Vorontsov
2008-10-13 16:48 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081008222815.GA20542@redhat.com \
--to=davej@redhat.com \
--cc=avorontsov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox