Re: fsl_upm compile failure.

Dave Jones
2008-10-08T23:33:57Z

On Thu, Oct 09, 2008 at 03:02:19AM +0400, Anton Vorontsov wrote:
> Hi,
>
> On Wed, Oct 08, 2008 at 06:28:15PM -0400, Dave Jones wrote:
> > Hi Anton,
> > I tried reenabling CONFIG_MTD_NAND_FSL_UPM in the Fedora kernel
> > today (currently on 2.6.27-rc9-git1), and got the error below.
> >
> > ERROR: "fsl_lbc_lock" [drivers/mtd/nand/fsl_upm.ko] undefined!
>
> Weird. It works for me with mpc836x_rdk_defconfig and
> MTD_NAND_FSL_UPM=m...
>
> Hm..
>
> CC drivers/mtd/nand/fsl_upm.mod.o
> LD [M] drivers/mtd/nand/fsl_upm.ko
>
> Can you send me the .config file you use?

http://davej.fedorapeople.org/ppc.config

> But the patch looks obviously correct. Much thanks for catching this.
>
> Though better option would be to uninline the fsl_upm_run_pattern()..
> it is quite big anyway... Something like this:

I'll leave it to you to decide what to push to Linus

Dave

--