Re: [RFC][PATCH 3/3] TXT: Intel(R) TXT and tboot kernel support

[Chris Wright <chrisw@sous-sol.org>]

* Pavel Machek (pavel@suse.cz) wrote:
> > +struct tboot_acpi_sleep_info {
> > +	u16 pm1a_cnt;
> > +	u16 pm1b_cnt;
> > +	u16 pm1a_evt;
> > +	u16 pm1b_evt;
> > +	u16 pm1a_cnt_val;
> > +	u16 pm1b_cnt_val;
> > +}  __attribute__ ((__packed__));
> > +
> > +struct tboot_shared {
> > +	/* version 0x01+ fields: */
> > +	struct tboot_uuid uuid; /* TBOOT_SHARED_UUID */
> > +	u32  version;      	/* Version number: 2 is current */
> > +	u32  log_addr;     	/* physical addr of tb_log_t log */
> > +	u32  shutdown_entry32;	/* entry point for tboot shutdown from
> > 32b */
> > +	u32  shutdown_entry64;	/* entry point for tboot shutdown from
> > 64b */
> 
> should these be function pointers?

I asked earlier, I didn't understand why it needs to be 2 fields, since
it's u32 in both cases and can't both be used at once.