From: Venki Pallipadi <venkatesh.pallipadi@intel.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Cyrill Gorcunov <gorcunov@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] Typo in x86 apic.c with DIVISOR setup
Date: Thu, 9 Oct 2008 17:22:04 -0700 [thread overview]
Message-ID: <20081010002203.GA23238@linux-os.sc.intel.com> (raw)
Fix a typo in x86 apic.c CONFG_X86_64 -> CONFIG_X86_64.
The intention looks like was to have divisor of 1 on x86_64 kernel.
Also, for DIVISOR value of 1 to work, APIC_TDR_DIV should also change
depending on divide by 1 or divide by 16 is used.
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
---
arch/x86/kernel/apic.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
Index: tip/arch/x86/kernel/apic.c
===================================================================
--- tip.orig/arch/x86/kernel/apic.c 2008-10-09 17:12:39.000000000 -0700
+++ tip/arch/x86/kernel/apic.c 2008-10-09 17:13:29.000000000 -0700
@@ -332,10 +332,12 @@ int lapic_get_maxlvt(void)
*/
/* Clock divisor */
-#ifdef CONFG_X86_64
+#ifdef CONFIG_X86_64
#define APIC_DIVISOR 1
+#define APIC_TDR_DIV APIC_TDR_DIV_1
#else
#define APIC_DIVISOR 16
+#define APIC_TDR_DIV APIC_TDR_DIV_16
#endif
/*
@@ -369,7 +371,7 @@ static void __setup_APIC_LVTT(unsigned i
tmp_value = apic_read(APIC_TDCR);
apic_write(APIC_TDCR,
(tmp_value & ~(APIC_TDR_DIV_1 | APIC_TDR_DIV_TMBASE)) |
- APIC_TDR_DIV_16);
+ APIC_TDR_DIV);
if (!oneshot)
apic_write(APIC_TMICT, clocks / APIC_DIVISOR);
next reply other threads:[~2008-10-10 0:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 0:22 Venki Pallipadi [this message]
2008-10-10 4:38 ` [PATCH] Typo in x86 apic.c with DIVISOR setup Cyrill Gorcunov
2008-10-10 5:10 ` Pallipadi, Venkatesh
2008-10-10 5:39 ` Cyrill Gorcunov
2008-10-10 9:01 ` Ingo Molnar
2008-10-10 11:14 ` Cyrill Gorcunov
2008-10-10 11:15 ` Maciej W. Rozycki
2008-10-10 11:16 ` Cyrill Gorcunov
2008-10-10 11:24 ` Maciej W. Rozycki
2008-10-10 11:56 ` Ingo Molnar
2008-10-10 12:38 ` Cyrill Gorcunov
2008-10-10 14:45 ` Ingo Molnar
2008-10-10 12:26 ` Cyrill Gorcunov
2008-10-10 16:01 ` Pallipadi, Venkatesh
2008-10-10 16:29 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010002203.GA23238@linux-os.sc.intel.com \
--to=venkatesh.pallipadi@intel.com \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox