From: Ingo Molnar <mingo@elte.hu>
To: Alan Jenkins <aj504@student.cs.york.ac.uk>
Cc: "Frédéric Weisbecker" <fweisbec@gmail.com>,
"Arjan van de Ven" <arjan@infradead.org>,
Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6] Tracing/fastboot: Enable boot tracing only during initcalls
Date: Fri, 10 Oct 2008 16:15:19 +0200 [thread overview]
Message-ID: <20081010141519.GA21104@elte.hu> (raw)
In-Reply-To: <48EF50B1.8070705@tuffmail.co.uk>
* Alan Jenkins <aj504@student.cs.york.ac.uk> wrote:
> > dont worry, i fixed them already when i applied your patch (and
> > that's all in latest tip/master).
> >
> > See the commit below - i sanitize most commit entries to make
> > subject lines more consistent (note the capitalization difference
> > between your submission and the end result), to improve paragraphing
> > and general structure.
>
> You missed the one backslash though...
>
> > -/* Should be started after do_pre_smp_initcalls() in init/main.c */
> > +/* Tells the boot tracer that the pre_smp_initcalls are finished.
> > + * So we are ready .
> > + * It doesn\'t enable sched events tracing however.
> > + * You have to call enable_boot_trace to do so.
> > + */
heh, indeed - fixed it. ( And there was a second backslash too,
introduced earlier. ;-)
Ingo
prev parent reply other threads:[~2008-10-10 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 12:36 [PATCH 1/6] Tracing/fastboot: Enable boot tracing only during initcalls Frederic Weisbecker
2008-10-10 10:58 ` Ingo Molnar
2008-10-10 11:02 ` Frédéric Weisbecker
2008-10-10 11:04 ` Ingo Molnar
2008-10-10 11:09 ` Frédéric Weisbecker
2008-10-10 12:55 ` Alan Jenkins
2008-10-10 14:15 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010141519.GA21104@elte.hu \
--to=mingo@elte.hu \
--cc=aj504@student.cs.york.ac.uk \
--cc=arjan@infradead.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox