From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Ingo Molnar <mingo@elte.hu>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 2/6] tracepoint: Check if the probe has been registered
Date: Fri, 10 Oct 2008 11:43:25 -0400 [thread overview]
Message-ID: <20081010154325.GC18353@Krystal> (raw)
In-Reply-To: <20081010140023.GA13137@elte.hu>
* Ingo Molnar (mingo@elte.hu) wrote:
>
> * Frederic Weisbecker <fweisbec@gmail.com> wrote:
>
> > If we try to remove a probe that has not been already registered, the
> > tracepoint_entry_remove_probe() function will dereference a NULL
> > pointer. Check the probe before removing it to avoid crashes.
> >
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> > ---
> > kernel/tracepoint.c | 8 ++++++++
> > 1 files changed, 8 insertions(+), 0 deletions(-)
>
> applied to tip/tracing/tracepoints, thanks Frederic!
>
> Mathieu, Steve, any objections/observations?
>
Looks good to me. Thanks !
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Mathieu
> Ingo
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2008-10-10 15:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 13:16 [PATCH 2/6] tracepoint: Check if the probe has been registered Frederic Weisbecker
2008-10-10 14:00 ` Ingo Molnar
2008-10-10 15:43 ` Mathieu Desnoyers [this message]
2008-10-10 16:53 ` Steven Rostedt
2008-10-10 16:55 ` Steven Rostedt
2008-10-13 9:43 ` Frédéric Weisbecker
2008-10-27 16:10 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010154325.GC18353@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox