From: Greg KH <greg@kroah.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, jens.axboe@oracle.com,
stable@kernel.org
Subject: Re: [stable] splice vs O_APPEND
Date: Fri, 10 Oct 2008 08:49:46 -0700 [thread overview]
Message-ID: <20081010154946.GB20231@kroah.com> (raw)
In-Reply-To: <E1KoEZM-0007Fb-5i@pomaz-ex.szeredi.hu>
On Fri, Oct 10, 2008 at 11:46:00AM +0200, Miklos Szeredi wrote:
> On Thu, 9 Oct 2008, Linus Torvalds wrote:
> > On Thu, 9 Oct 2008, Miklos Szeredi wrote:
> > >
> > > The thing is, the append-only attribute is absolutely useless without
> > > being able to depend on it. So in that sense I think the IS_APPEND
> > > issue is important, and I'm fine with your original proposal for that
> > > (except we don't need the IS_IMMUTABLE check).
> >
> > Heh. In the meantime, I had grown to hate that more complex patch.
> >
> > So because I do see your point with IS_APPEND (being different from
> > O_APPEND), but because I also think that O_APPEND itself is a gray and
> > murky area, I just committed the following. I doubt anybody will ever even
> > notice it, but while I think it's all debatable, we might as well debate
> > it with this in place. I do agree that it's "safer" behaviour.
>
> Thanks.
>
> I suspect this qualifies for stable kernels too. Stable team, can you
> please add this to your queue?
Queue for which kernel releases? .25, .26, and/or .27?
thanks,
greg k-h
next prev parent reply other threads:[~2008-10-10 15:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 15:02 splice vs O_APPEND Miklos Szeredi
2008-10-09 15:37 ` Linus Torvalds
2008-10-09 16:04 ` Miklos Szeredi
2008-10-09 16:17 ` Linus Torvalds
2008-10-09 16:30 ` Miklos Szeredi
2008-10-09 19:22 ` Linus Torvalds
2008-10-09 19:51 ` Miklos Szeredi
2008-10-09 21:14 ` Linus Torvalds
2008-10-09 21:20 ` Jens Axboe
2008-10-09 21:27 ` Linus Torvalds
2008-10-10 9:46 ` Miklos Szeredi
2008-10-10 10:06 ` Jens Axboe
2008-10-10 15:49 ` Greg KH [this message]
2008-10-10 16:05 ` [stable] " Miklos Szeredi
2008-10-10 16:20 ` Greg KH
2008-10-10 10:23 ` Michael Kerrisk
2008-10-09 16:30 ` Andreas Schwab
2008-10-09 16:43 ` Miklos Szeredi
2008-10-09 17:03 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010154946.GB20231@kroah.com \
--to=greg@kroah.com \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox