From: Andrew Morton <akpm@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: ying.huang@intel.com, linux-kernel@vger.kernel.org,
hpa@zytor.com, tglx@linutronix.de,
Matthew Wilcox <matthew@wil.cx>
Subject: Re: [PATCH -mm -v5] Separate atomic_t declaration from asm/atomic.h into asm/atomic_def.h
Date: Fri, 10 Oct 2008 15:54:50 -0700 [thread overview]
Message-ID: <20081010155450.094288b4.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081010214958.GA7708@elte.hu>
On Fri, 10 Oct 2008 23:49:58 +0200
Ingo Molnar <mingo@elte.hu> wrote:
>
> * Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > On Wed, 08 Oct 2008 17:44:30 +0800
> > Huang Ying <ying.huang@intel.com> wrote:
> >
> > > From: Huang Ying <ying.huang@intel.com>
> > >
> > > asm/atomic.h contains both declaration and implementation of atomic_t. So
> > > there are some implementation related files included in asm/atomic.h. And
> > > atomic_t is a typedef. Combination of above makes it impossible to use
> > > atomic_t in files included by atomic.h. Such as atomic_t can not be used
> > > in linux/kernel.h on i386, because it is included by asm/atomic.h.
> > >
> > > It is reasonable to separate declaration from implementation. So a new
> > > file atomic_types.h is added for every architecture to accommodate the
> > > declaration of atomic_t.
> > >
> > > Includes fixes from Andrew Moton.
> > >
> > > Signed-off-by: Huang Ying <ying.huang@intel.com>
> > > Reviewed-by: Ingo Molnar <mingo@elte.hu>
> >
> > The difference between what-i-currently-have and what-you-just-sent is
> > below. It's quite large.
> >
> > Can you explain this update please?
>
> i've been giving review feedback to make it all fit into existing
> namespace concepts better. Should have no change in functionality. (But
> i have not tested it)
>
I have a note here that Matthew has proposed a different way of doing
all this. I don't immediately recall the details.
Can we get a refresh on all of that please?
next prev parent reply other threads:[~2008-10-10 22:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 9:44 [PATCH -mm -v5] Separate atomic_t declaration from asm/atomic.h into asm/atomic_def.h Huang Ying
2008-10-10 21:43 ` Andrew Morton
2008-10-10 21:49 ` Ingo Molnar
2008-10-10 22:54 ` Andrew Morton [this message]
2008-10-14 18:47 ` Matthew Wilcox
2008-10-15 22:11 ` Andrew Morton
2008-10-15 22:19 ` Matthew Wilcox
2008-10-15 22:31 ` Andrew Morton
2008-10-18 4:00 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010155450.094288b4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox