From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [git pull] x86 updates for v2.6.28, phase #2 - PAT updates
Date: Fri, 10 Oct 2008 18:56:47 +0200 [thread overview]
Message-ID: <20081010165647.GA4363@elte.hu> (raw)
In-Reply-To: <20081010164537.GA23664@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> > which makes both the original commit _and_ the revert just totally
> > pointless, because we didn't learn anything.
>
> hm, those reverts werent supposed to survive. Again, my bad. I'll
> clean it out.
>
> Here is how the screwup happened: a series was sent, i applied it,
> found a test failure with it and reported it:
>
> http://www.uwsg.iu.edu/hypermail/linux/kernel/0809.1/2388.html
>
> but to be able to continue testing i temporarily reverted those bits
> manually in reverse order, because it took some down to pin down the
> breakage and these bits got intermixed with other commits - and i did
> not want to rebase commits that came after the broken series.
Correction: i did the reverts shortly before applying the v2 series - so
it was fully technical. I wanted to do a line by line review of the fix
(and did it), because the lockup took quite some time to pin down. To
avoid this mistake i could also have hard-reset the full v1 series and
could have redone the whole topic.
What's the best Git way to avoid such mishaps? I try to avoid resets and
rebases of already pushed out bits as much as possible, because that is
both risky because information can be lost and asocial because ongoing
work of contributors can be disturbed.
Ingo
next prev parent reply other threads:[~2008-10-10 16:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 23:49 [git pull] x86 updates for v2.6.28, phase #2 - PAT updates Ingo Molnar
2008-10-10 16:27 ` Linus Torvalds
2008-10-10 16:45 ` Ingo Molnar
2008-10-10 16:56 ` Ingo Molnar [this message]
2008-10-10 17:23 ` Linus Torvalds
2008-10-10 17:04 ` Ingo Molnar
2008-10-10 17:34 ` Linus Torvalds
2008-10-10 17:41 ` [git pull, take 2] " Ingo Molnar
2008-10-10 18:15 ` Linus Torvalds
2008-10-10 18:33 ` Ingo Molnar
2008-10-10 18:17 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010165647.GA4363@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox