From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Venki Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: apic - unify APIC_DIVISOR
Date: Fri, 10 Oct 2008 23:11:27 +0400 [thread overview]
Message-ID: <20081010191127.GA31036@localhost> (raw)
In-Reply-To: <20081010190350.GA25931@linux-os.sc.intel.com>
[Venki Pallipadi - Fri, Oct 10, 2008 at 12:03:50PM -0700]
...
|
| If there is no pressing reason to change the initial calibration value, how
| about the simple patch below.
|
| The 10^9 value that is used for 100 mS calibration time is pretty big as
| tglx's comment points out. We will only underflow it if there is a
| bus clock running at 10 GHz * 16 = 160 Ghz.
|
| This way we will not fix something that is not really broken today and will not
| break in foreseeable future.
|
| Thanks,
| Venki
I personally have no objection. Thanks Venki.
Btw since Ingo already picked the patch from me
maybe you could make a patch with numbers you mentoined
(ie changelog) and fix 0xffffffff to 10^9?
- Cyrill -
next prev parent reply other threads:[~2008-10-10 19:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 15:00 [PATCH] x86: apic - unify APIC_DIVISOR Cyrill Gorcunov
2008-10-10 15:07 ` Ingo Molnar
2008-10-10 15:47 ` Maciej W. Rozycki
2008-10-10 16:11 ` Pallipadi, Venkatesh
2008-10-10 16:31 ` Cyrill Gorcunov
2008-10-10 17:07 ` Pallipadi, Venkatesh
2008-10-10 17:16 ` Cyrill Gorcunov
2008-10-10 19:03 ` Venki Pallipadi
2008-10-10 19:11 ` Cyrill Gorcunov [this message]
2008-10-10 19:17 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010191127.GA31036@localhost \
--to=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox