From: Ingo Molnar <mingo@elte.hu>
To: Greg KH <greg@kroah.com>
Cc: Stefan Bader <stefan.bader@canonical.com>,
stable@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Yinghai Lu <yinghai@kernel.org>,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [stable] [PATCH] x86: Reserve FIRST_DEVICE_VECTOR in used_vectors bitmap
Date: Fri, 10 Oct 2008 22:23:50 +0200 [thread overview]
Message-ID: <20081010202350.GA11090@elte.hu> (raw)
In-Reply-To: <20081010201610.GA32164@kroah.com>
* Greg KH <greg@kroah.com> wrote:
> On Fri, Oct 10, 2008 at 04:01:54PM -0400, Stefan Bader wrote:
> > Affected: 2.6.24-2.6.27
> >
> > Someone from the community found out, that after repeatedly unloading and
> > loading a device driver that uses MSI IRQs, the system eventually assigned
> > the vector initially reserved for IRQ0 to the device driver.
> >
> > The reason for this is, that although IRQ0 is tied to the FIRST_DEVICE_VECTOR
> > when declaring the irq_vector table, the corresponding bit in the used_vectors
> > map is not set. So, if vectors are released and assigned often enough, the
> > vector will get assigned to another interrupt. This happens more often with
> > MSI interrupts as those are exclusively using a vector.
> >
> > Fix this by setting the bit for the FIRST_DEVICE_VECTOR in the bitmap.
> >
> > Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
>
> Hint, if you want patches to go into the -stable tree, just add:
> cc: Stable <stable@kernel.org>
> to the patch when you submit it in the signed-off-by area, and it will
> be automatically sent to us when it goes into the main kernel tree.
yes. Note that this is a special case, as there will be no upstream
commit to tag with Cc: <stable@kernel.org>, because this bug got
eliminated via not backportable means: APIC code unification.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2008-10-10 20:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 20:01 [PATCH] x86: Reserve FIRST_DEVICE_VECTOR in used_vectors bitmap Stefan Bader
2008-10-10 20:16 ` [stable] " Greg KH
2008-10-10 20:23 ` Ingo Molnar [this message]
2008-10-10 20:29 ` Greg KH
2008-10-10 20:36 ` Stefan Bader
2008-10-10 20:41 ` Greg KH
2008-10-10 20:16 ` Greg KH
2008-10-10 20:22 ` Stefan Bader
2008-10-10 20:18 ` Greg KH
2008-10-10 20:24 ` Stefan Bader
2008-10-10 20:35 ` H. Peter Anvin
2008-10-10 20:41 ` Greg KH
2008-10-10 20:50 ` Alan Cox
2008-10-10 21:12 ` Greg KH
2008-10-10 21:49 ` Alan Cox
2008-10-10 22:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010202350.GA11090@elte.hu \
--to=mingo@elte.hu \
--cc=greg@kroah.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=stefan.bader@canonical.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox