public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Stefan Bader <stefan.bader@canonical.com>
Cc: linux-kernel@vger.kernel.org, stable@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
	Yinghai Lu <yinghai@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [stable] [PATCH] x86: Reserve FIRST_DEVICE_VECTOR in used_vectors bitmap
Date: Fri, 10 Oct 2008 13:41:12 -0700	[thread overview]
Message-ID: <20081010204112.GA32357@kroah.com> (raw)
In-Reply-To: <48EFBCBB.6050104@canonical.com>

On Fri, Oct 10, 2008 at 04:36:11PM -0400, Stefan Bader wrote:
> Greg KH wrote:
> > On Fri, Oct 10, 2008 at 10:23:50PM +0200, Ingo Molnar wrote:
> >> * Greg KH <greg@kroah.com> wrote:
> >>
> >>> On Fri, Oct 10, 2008 at 04:01:54PM -0400, Stefan Bader wrote:
> >>>> Affected: 2.6.24-2.6.27
> >>>>
> >>>> Someone from the community found out, that after repeatedly unloading and
> >>>> loading a device driver that uses MSI IRQs, the system eventually assigned
> >>>> the vector initially reserved for IRQ0 to the device driver.
> >>>>
> >>>> The reason for this is, that although IRQ0 is tied to the FIRST_DEVICE_VECTOR
> >>>> when declaring the irq_vector table, the corresponding bit in the used_vectors
> >>>> map is not set. So, if vectors are released and assigned often enough, the
> >>>> vector will get assigned to another interrupt. This happens more often with
> >>>> MSI interrupts as those are exclusively using a vector.
> >>>>
> >>>> Fix this by setting the bit for the FIRST_DEVICE_VECTOR in the bitmap.
> >>>>
> >>>> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
> >>> Hint, if you want patches to go into the -stable tree, just add:
> >>> 	cc: Stable <stable@kernel.org>
> >>> to the patch when you submit it in the signed-off-by area, and it will
> >>> be automatically sent to us when it goes into the main kernel tree.
> >> yes. Note that this is a special case, as there will be no upstream 
> >> commit to tag with Cc: <stable@kernel.org>, because this bug got 
> >> eliminated via not backportable means: APIC code unification.
> >>
> >> Acked-by: Ingo Molnar <mingo@elte.hu>
> > 
> > So this is a -stable release only patch?  .28 will never get/need this?
> > 
> > thanks,
> > 
> > greg k-h
> 
> Correct. Tried to hint this by the Affected line but should have been more verbose.

Great, thanks for letting me know, I'll queue it up for -stable.

Oh, next time, please don't attach patches in base64 format, that's a
pain in the ass...

thanks,

greg k-h

  reply	other threads:[~2008-10-10 20:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-10 20:01 [PATCH] x86: Reserve FIRST_DEVICE_VECTOR in used_vectors bitmap Stefan Bader
2008-10-10 20:16 ` [stable] " Greg KH
2008-10-10 20:23   ` Ingo Molnar
2008-10-10 20:29     ` Greg KH
2008-10-10 20:36       ` Stefan Bader
2008-10-10 20:41         ` Greg KH [this message]
2008-10-10 20:16 ` Greg KH
2008-10-10 20:22   ` Stefan Bader
2008-10-10 20:18 ` Greg KH
2008-10-10 20:24   ` Stefan Bader
2008-10-10 20:35   ` H. Peter Anvin
2008-10-10 20:41     ` Greg KH
2008-10-10 20:50       ` Alan Cox
2008-10-10 21:12         ` Greg KH
2008-10-10 21:49           ` Alan Cox
2008-10-10 22:09             ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081010204112.GA32357@kroah.com \
    --to=greg@kroah.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=stable@kernel.org \
    --cc=stefan.bader@canonical.com \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox