Re: libata: set queue SSD flag for SSD devices

Alan Cox
2008-10-10T19:26:38Z

> + ATA_ID_ROT_SPEED = 217,
> ATA_ID_PIO4 = (1 << 1),
>
> ATA_ID_SERNO_LEN = 20,
> @@ -691,6 +692,11 @@ static inline int ata_id_is_cfa(const u16 *id)
> return 0;
> }
>
> +static inline int ata_id_is_ssd(const u16 *id)
> +{
> + return id[ATA_ID_ROT_SPEED] == 0x01;
> +}

This patch is buggy.

Word 217 only has a defined meaning in late revision ATA standards so a
version check is needed. Please copy ATA patch copies to linux-ide.

Alan