Re: [PATCH] block: add BIG FAT WARNING to CONFIG_DEBUG_BLOCK_EXT_DEVT

Tejun Heo
2008-10-14T17:33:55Z

Christoph Hellwig wrote:
> On Mon, Oct 13, 2008 at 03:41:35PM +0900, Tejun Heo wrote:
>> CONFIG_DEBUG_BLOCK_EXT_DEVT can break booting even on some modern
>> distros. Add BIG FAT WARNING to keep people at a safe distance.
>
> Just remove the whole "debug" code. It clutters up all block drivers with
> ifdefs and doesn't actually provide any benefit.

Well, it's mostly intended for distros so that they can enable the
option and detect places where they assume consecutive minors as
otherwise most of those will go unnoticed until some user finally tries
to use more than 16 partitions. As most distros are broken at the
moment, I'm more inclined to keep the debug option and planning on
enabling it during the next devel cycle of openSUSE and ask RH and other
distros to do the same. It adds ifdefs to ide-disk and sd, which isn't
too much. I think it would be good to keep it until at least distros
break out of the consecutive or fixed device number assumption.

Thanks.

--
tejun