From: Grant Grundler <grundler@parisc-linux.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Grant Grundler <grundler@parisc-linux.org>,
Matthew Wilcox <matthew@wil.cx>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] pci: print out DMA mask info
Date: Sun, 12 Oct 2008 01:11:57 -0600 [thread overview]
Message-ID: <20081012071157.GA20056@colo.lackof.org> (raw)
In-Reply-To: <48EE8E55.4000009@kernel.org>
On Thu, Oct 09, 2008 at 04:05:57PM -0700, Yinghai Lu wrote:
> Grant Grundler wrote:
> > On Thu, Oct 09, 2008 at 02:51:32PM -0700, Yinghai Lu wrote:
> >> On Thu, Oct 9, 2008 at 2:35 PM, Matthew Wilcox <matthew@wil.cx> wrote:
> >>> Why's that interesting to the sysadmin of the machine? To the driver
> >>> writer, certainly. But what's the use of it to the people using the
> >>> machine?
> > ...
> >> make linux kernel act like black box as other os?
> >
> > I don't understand your reply.
> > If someone thinks linux is a black box, printing this message won't help them.
> >
> could find out easily why some driver doesn't set dma mask correctly.
> like why
> qlogic qla2xxx only set consistent to 64bit,
> emulex lpfc not set consistent to 64bit
I agree making the information available is a good idea. It's just
not going to help anyone 99% of the time and isn't a requirement for
booting the machine.
> >
> > "To flag use of bounce buffer or other suboptimal behaviors" could be debated.
> >
> >
> > Regarding associating the output with other PCI messages, I'd hope the fact
> > that the /sys entry is in the same directory as other sys files would be
> > enough clue to associate those together. e.g.:
> > grundler <2068>cd /sys/bus/pci/devices/0000\:01\:00.0/
> > grundler <2069>ls
> > broken_parity_status driver@ irq resource0 subsystem_device
> > bus@ enable local_cpus resource1 subsystem_vendor
> > class i2c-0/ modalias resource3 uevent
> > config i2c-1/ power/ rom vendor
> > device i2c-2/ resource subsystem@
> >
>
> add dma_mask coherent_dma_mask here?
Yes, if there is no other more obvious place.
It's just a suggestion which I happen to think is better than
adding more boot time messages.
thanks,
grant
next prev parent reply other threads:[~2008-10-12 7:12 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 23:02 [PATCH] pci: print out DMA mask info Yinghai Lu
2008-10-09 21:18 ` Grant Grundler
2008-10-09 21:27 ` Yinghai Lu
2008-10-09 21:35 ` Matthew Wilcox
2008-10-09 21:51 ` Yinghai Lu
2008-10-09 22:55 ` Grant Grundler
2008-10-09 23:05 ` Yinghai Lu
2008-10-10 2:40 ` FUJITA Tomonori
2008-10-10 4:56 ` Yinghai Lu
2008-10-10 6:08 ` FUJITA Tomonori
2008-10-10 6:32 ` Yinghai Lu
2008-10-10 7:32 ` FUJITA Tomonori
2008-10-12 7:16 ` Grant Grundler
2008-10-10 22:45 ` Grant Grundler
2008-10-14 6:50 ` FUJITA Tomonori
2008-10-12 7:11 ` Grant Grundler [this message]
2008-10-23 1:45 ` [PATCH] pci: show dma_mask bits in /sys Yinghai Lu
2008-10-23 3:28 ` Matthew Wilcox
2008-10-23 4:19 ` Yinghai Lu
2008-10-23 6:44 ` Grant Grundler
2008-10-23 8:38 ` Rolf Eike Beer
2008-10-23 15:39 ` Greg KH
2008-10-23 18:37 ` H. Peter Anvin
2008-10-23 19:36 ` Grant Grundler
2008-10-23 19:49 ` Greg KH
2008-10-24 10:50 ` Andi Kleen
2008-11-01 17:10 ` Grant Grundler
2008-10-23 6:48 ` Grant Grundler
2008-10-23 6:51 ` Yinghai Lu
2008-10-23 19:28 ` Grant Grundler
2008-10-10 2:40 ` [PATCH] pci: print out DMA mask info FUJITA Tomonori
2008-10-10 2:59 ` FUJITA Tomonori
2008-10-10 2:40 ` FUJITA Tomonori
2008-10-10 15:48 ` Jesse Barnes
2008-10-10 16:19 ` Yinghai Lu
2008-10-10 16:28 ` Jesse Barnes
2008-10-10 16:33 ` Matthew Wilcox
2008-10-10 16:46 ` Yinghai Lu
2008-10-10 17:12 ` Matthew Wilcox
2008-10-10 17:18 ` Roland Dreier
2008-10-12 7:38 ` Grant Grundler
2008-10-12 7:20 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081012071157.GA20056@colo.lackof.org \
--to=grundler@parisc-linux.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox