From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
To: Jeff Layton <jlayton@redhat.com>, "Steve French" <smfrench@gmail.com>
Cc: rjw@sisk.pl, "David Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
"samba-technical@lists.samba.org"
<samba-technical@lists.samba.org>,
"linux-cifs-client@lists.samba.org"
<linux-cifs-client@lists.samba.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [linux-cifs-client] Fwd: [PATCH] Fix CIFS compilation with CONFIG_KEYS unset
Date: Sun, 12 Oct 2008 22:12:26 +0800 [thread overview]
Message-ID: <20081012140936.M27503@cooldavid.org> (raw)
In-Reply-To: <20081012095903.33427ee8@tleilax.poochiereds.net>
On Sun, 12 Oct 2008 09:59:03 -0400, Jeff Layton wrote
> On Sun, 12 Oct 2008 08:40:39 -0500
> "Steve French" <smfrench@gmail.com> wrote:
>
> > Rafael and Guo-Fu,
> > The following change to address the compile error that you noted is
> > slightly different than what you suggested but should fix what you
> > found.
> >
>
> Actually, I like Adrian/Rafael's fix better. I think we should avoid
> cluttering up the code with #ifdef's where possible. key_put() already
> is a no-op when CONFIG_KEYS is disabled. We might as well do the same
> thing with key_revoke().
I found that my patch was not reasonable at all.
And I agree with Jeff.
Guo-Fu Tseng
next prev parent reply other threads:[~2008-10-12 14:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-12 11:15 [PATCH] Fix CIFS compilation with CONFIG_KEYS unset Rafael J. Wysocki
2008-10-12 13:40 ` Fwd: " Steve French
2008-10-12 13:42 ` Guo-Fu Tseng
2008-10-12 13:59 ` [linux-cifs-client] " Jeff Layton
2008-10-12 14:12 ` Guo-Fu Tseng [this message]
2008-10-12 16:53 ` Steve French
2008-10-12 16:57 ` Steve French
2008-10-12 17:09 ` Rafael J. Wysocki
2008-10-12 18:47 ` Steve French
2008-10-12 20:16 ` Jeff Layton
2008-10-12 20:38 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081012140936.M27503@cooldavid.org \
--to=cooldavid@cooldavid.org \
--cc=davem@davemloft.net \
--cc=jlayton@redhat.com \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=samba-technical@lists.samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox