From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Steve French" <smfrench@gmail.com>
Cc: "Jeff Layton" <jlayton@redhat.com>,
"David Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
"samba-technical@lists.samba.org"
<samba-technical@lists.samba.org>,
"linux-cifs-client@lists.samba.org"
<linux-cifs-client@lists.samba.org>,
cooldavid@cooldavid.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [linux-cifs-client] Fwd: [PATCH] Fix CIFS compilation with CONFIG_KEYS unset
Date: Sun, 12 Oct 2008 19:09:52 +0200 [thread overview]
Message-ID: <200810121909.53233.rjw@sisk.pl> (raw)
In-Reply-To: <524f69650810120957t1a81f23lf3fd75fee78e72c3@mail.gmail.com>
On Sunday, 12 of October 2008, Steve French wrote:
> On Sun, Oct 12, 2008 at 11:53 AM, Steve French <smfrench@gmail.com> wrote:
> > On Sun, Oct 12, 2008 at 8:59 AM, Jeff Layton <jlayton@redhat.com> wrote:
> >> On Sun, 12 Oct 2008 08:40:39 -0500
> >> "Steve French" <smfrench@gmail.com> wrote:
> >>
> >> Actually, I like Adrian/Rafael's fix better. I think we should avoid
> >> cluttering up the code with #ifdef's where possible. key_put() already
> >> is a no-op when CONFIG_KEYS is disabled. We might as well do the same
> >> thing with key_revoke().
> > I don't think it matters much - but we probably shouldn't be
> > overriding global functions.
>
> To clarify, I like fixing it in keys.h better than overriding it in
> cifs, but in the meantime we need an ifdef in cifs until keys.h
> changes.
Well, adding an empty definition for key_revoke() in the !CONFIG_KEYS case
makes sense anyway IMO.
next prev parent reply other threads:[~2008-10-12 17:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-12 11:15 [PATCH] Fix CIFS compilation with CONFIG_KEYS unset Rafael J. Wysocki
2008-10-12 13:40 ` Fwd: " Steve French
2008-10-12 13:42 ` Guo-Fu Tseng
2008-10-12 13:59 ` [linux-cifs-client] " Jeff Layton
2008-10-12 14:12 ` Guo-Fu Tseng
2008-10-12 16:53 ` Steve French
2008-10-12 16:57 ` Steve French
2008-10-12 17:09 ` Rafael J. Wysocki [this message]
2008-10-12 18:47 ` Steve French
2008-10-12 20:16 ` Jeff Layton
2008-10-12 20:38 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810121909.53233.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=cooldavid@cooldavid.org \
--cc=davem@davemloft.net \
--cc=jlayton@redhat.com \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox