[PATCH] 2.6.27-git2 - fix build error at csum_ipv6_magic()

[PATCH] 2.6.27-git2 - fix build error at csum_ipv6_magic()

[Kamalesh Babulal]

Hi,
  2.6.27-git2 kernel build fails with allyesconfig on powerpc with 
build error 

<introduced by commit 01f2e4ead2c51226ed1283ef6a8388ca6f4cff8f> 

CC    drivers/net/enic/enic_main.o
drivers/net/enic/enic_main.c: In function ‘enic_queue_wq_skb_tso’:
drivers/net/enic/enic_main.c:576: error: implicit declaration of function ‘csum_ipv6_magic’
make[3]: *** [drivers/net/enic/enic_main.o] Error 1

<introduced by commit c4e84bde1d595d857d3c74b49b9c45cc770df792>

drivers/net/qlge/qlge_main.c: In function ‘ql_tso’:
drivers/net/qlge/qlge_main.c:1862: error: implicit declaration of function ‘csum_ipv6_magic’
make[3]: *** [drivers/net/qlge/qlge_main.o] Error 1
  
<introduced by commit 95252236e73e789dd186ce796a2abc60b3a61ebe>

drivers/net/jme.c: In function ‘jme_tx_tso’:
drivers/net/jme.c:1784: error: implicit declaration of function ‘csum_ipv6_magic’
make[2]: *** [drivers/net/jme.o] Error 1

The patch is build tested only.

Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
---
 drivers/net/enic/enic_main.c |    1 +
 drivers/net/jme.c            |    1 +
 drivers/net/qlge/qlge_main.c |    1 +
 3 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index f3a47a8..180e968 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -34,6 +34,7 @@
 #include <linux/ip.h>
 #include <linux/ipv6.h>
 #include <linux/tcp.h>
+#include <net/ip6_checksum.h>
 
 #include "cq_enet_desc.h"
 #include "vnic_dev.h"
diff --git a/drivers/net/jme.c b/drivers/net/jme.c
index 5f9a131..d86e809 100644
--- a/drivers/net/jme.c
+++ b/drivers/net/jme.c
@@ -38,6 +38,7 @@
 #include <linux/tcp.h>
 #include <linux/udp.h>
 #include <linux/if_vlan.h>
+#include <net/ip6_checksum.h>
 #include "jme.h"
 
 static int force_pseudohp = -1;
diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
index 3af822b..6675723 100644
--- a/drivers/net/qlge/qlge_main.c
+++ b/drivers/net/qlge/qlge_main.c
@@ -40,6 +40,7 @@
 #include <linux/delay.h>
 #include <linux/mm.h>
 #include <linux/vmalloc.h>
+#include <net/ip6_checksum.h>
 
 #include "qlge.h"
 
-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

Re: [PATCH] 2.6.27-git2 - fix build error at csum_ipv6_magic()

[Guo-Fu Tseng]

On Mon, 13 Oct 2008 17:44:41 +0530, Kamalesh Babulal wrote
> Hi,
>   2.6.27-git2 kernel build fails with allyesconfig on powerpc with 
> build error
> 
> <introduced by commit 01f2e4ead2c51226ed1283ef6a8388ca6f4cff8f>
> 
> CC    drivers/net/enic/enic_main.o
> drivers/net/enic/enic_main.c: In function `nic_queue_wq_skb_tso`:
> drivers/net/enic/enic_main.c:576: error: implicit declaration of function `sum_ipv6_magic`
> make[3]: *** [drivers/net/enic/enic_main.o] Error 1
> 
> <introduced by commit c4e84bde1d595d857d3c74b49b9c45cc770df792>
> 
> drivers/net/qlge/qlge_main.c: In function `l_tso`:
> drivers/net/qlge/qlge_main.c:1862: error: implicit declaration of function `sum_ipv6_magic`
> make[3]: *** [drivers/net/qlge/qlge_main.o] Error 1
> 
> <introduced by commit 95252236e73e789dd186ce796a2abc60b3a61ebe>
> 
> drivers/net/jme.c: In function `me_tx_tso`:
> drivers/net/jme.c:1784: error: implicit declaration of function `sum_ipv6_magic`
> make[2]: *** [drivers/net/jme.o] Error 1
> 
> The patch is build tested only.
> 
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> ---
Thank you Kamalesh.

But since <net/ip6_checksum.h> compensate the lack of
`csum_ipv6_magic` function defined in <asm/checksum.h>
of some architecture, should <net/ip6_checksum.h> be
included in <net/checksum.h> as well?

BTW, if there is a patch against jme driver which I maintain,
and I just simply agree with it, should I silently noticed that
and let someone like Jeff or David to review/apply it,
or should I reply an ack of it?

Guo-Fu Tseng

Re: [PATCH] 2.6.27-git2 - fix build error at csum_ipv6_magic()

[David Miller]

From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
Date: Tue, 14 Oct 2008 03:28:14 +0800

> But since <net/ip6_checksum.h> compensate the lack of
> `csum_ipv6_magic` function defined in <asm/checksum.h>
> of some architecture, should <net/ip6_checksum.h> be
> included in <net/checksum.h> as well?

No, the standard convention is that if you need to call this
ipv6 checksumming routine you include net/ip6_checksum.h
From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
Date: Tue, 14 Oct 2008 03:28:14 +0800

> BTW, if there is a patch against jme driver which I maintain,
> and I just simply agree with it, should I silently noticed that
> and let someone like Jeff or David to review/apply it,
> or should I reply an ack of it?

You can ACK it and I usually apply patches like this directly.

Re: [PATCH] 2.6.27-git2 - fix build error at csum_ipv6_magic()

[Ron Mercer]

Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>

for qlge:
Thanks Kamalesh



On Mon, Oct 13, 2008 at 05:44:41PM +0530, Kamalesh Babulal wrote:
> Hi,
>   2.6.27-git2 kernel build fails with allyesconfig on powerpc with 
> build error 
> 
> <introduced by commit 01f2e4ead2c51226ed1283ef6a8388ca6f4cff8f> 
> 
> CC    drivers/net/enic/enic_main.o
> drivers/net/enic/enic_main.c: In function ‘enic_queue_wq_skb_tso’:
> drivers/net/enic/enic_main.c:576: error: implicit declaration of function ‘csum_ipv6_magic’
> make[3]: *** [drivers/net/enic/enic_main.o] Error 1
> 
> <introduced by commit c4e84bde1d595d857d3c74b49b9c45cc770df792>
> 
> drivers/net/qlge/qlge_main.c: In function ‘ql_tso’:
> drivers/net/qlge/qlge_main.c:1862: error: implicit declaration of function ‘csum_ipv6_magic’
> make[3]: *** [drivers/net/qlge/qlge_main.o] Error 1
>   
> <introduced by commit 95252236e73e789dd186ce796a2abc60b3a61ebe>
> 
> drivers/net/jme.c: In function ‘jme_tx_tso’:
> drivers/net/jme.c:1784: error: implicit declaration of function ‘csum_ipv6_magic’
> make[2]: *** [drivers/net/jme.o] Error 1
> 
> The patch is build tested only.
> 
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> ---
>  drivers/net/enic/enic_main.c |    1 +
>  drivers/net/jme.c            |    1 +
>  drivers/net/qlge/qlge_main.c |    1 +
>  3 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
> index f3a47a8..180e968 100644
> --- a/drivers/net/enic/enic_main.c
> +++ b/drivers/net/enic/enic_main.c
> @@ -34,6 +34,7 @@
>  #include <linux/ip.h>
>  #include <linux/ipv6.h>
>  #include <linux/tcp.h>
> +#include <net/ip6_checksum.h>
>  
>  #include "cq_enet_desc.h"
>  #include "vnic_dev.h"
> diff --git a/drivers/net/jme.c b/drivers/net/jme.c
> index 5f9a131..d86e809 100644
> --- a/drivers/net/jme.c
> +++ b/drivers/net/jme.c
> @@ -38,6 +38,7 @@
>  #include <linux/tcp.h>
>  #include <linux/udp.h>
>  #include <linux/if_vlan.h>
> +#include <net/ip6_checksum.h>
>  #include "jme.h"
>  
>  static int force_pseudohp = -1;
> diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
> index 3af822b..6675723 100644
> --- a/drivers/net/qlge/qlge_main.c
> +++ b/drivers/net/qlge/qlge_main.c
> @@ -40,6 +40,7 @@
>  #include <linux/delay.h>
>  #include <linux/mm.h>
>  #include <linux/vmalloc.h>
> +#include <net/ip6_checksum.h>
>  
>  #include "qlge.h"
>  
> -- 
> Thanks & Regards,
> Kamalesh Babulal,
> Linux Technology Center,
> IBM, ISTL.

Re: [PATCH] 2.6.27-git2 - fix build error at csum_ipv6_magic()

[David Miller]

From: Ron Mercer <ron.mercer@qlogic.com>
Date: Mon, 13 Oct 2008 16:09:57 -0700

> Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>

I've applied Kamalesh's patch, thanks everyone.