From: Jianjun Kong <kongjianjun@gmail.com>
To: "Simon Holm Th�gersen" <odie@cs.aau.dk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Alan Cox <alan@redhat.com>, David Miller <davem@davemloft.net>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: remove unused variable
Date: Tue, 14 Oct 2008 13:50:47 +0800 [thread overview]
Message-ID: <20081014055047.GA6552@ubuntu> (raw)
In-Reply-To: <1223938711.21717.16.camel@odie.local>
On Tue, Oct 14, 2008 at 12:58:31AM +0200, Simon Holm Th�gersen wrote:
>This fixes the following compile warning:
>
>drivers/serial/8250.c: In function 'serial8250_init':
>drivers/serial/8250.c:2963: warning: unused variable 'i'
>
>that was introduced by b70ac771 (serial: allow 8250 to be used on sparc)
>that removed the last use of the variable.
>
>Signed-off-by: Simon Holm Thøgersen <odie@cs.aau.dk>
>---
> drivers/serial/8250.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
>index d4104a3..625fc20 100644
>--- a/drivers/serial/8250.c
>+++ b/drivers/serial/8250.c
>@@ -2960,7 +2960,7 @@ EXPORT_SYMBOL(serial8250_unregister_port);
>
> static int __init serial8250_init(void)
> {
>- int ret, i;
>+ int ret;
>
> if (nr_uarts > UART_NR)
> nr_uarts = UART_NR;
I find those code in this function __init serial8250_init(void)
for (i = 0; i < NR_IRQS; i++)
spin_lock_init(&irq_lists[i].lock);
So you do not remove the 'i'.
--
Jianjun Kong | Happy Hacking
HomePage: http://kongove.cn
Gtalk: kongjianjun@gmail.com
next prev parent reply other threads:[~2008-10-14 5:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 22:58 [PATCH] serial: remove unused variable Simon Holm Thøgersen
2008-10-14 5:50 ` Jianjun Kong [this message]
2008-10-14 7:08 ` Simon Holm Thøgersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014055047.GA6552@ubuntu \
--to=kongjianjun@gmail.com \
--cc=alan@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=odie@cs.aau.dk \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox