public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	Dmitry Torokhov <dtor@insightbb.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] serial: fix serial port lock init
Date: Tue, 14 Oct 2008 12:22:53 +0200	[thread overview]
Message-ID: <20081014102253.GA13503@elte.hu> (raw)
In-Reply-To: <20081014065541.GA11047@elte.hu>


> [   31.099528] BUG: spinlock bad magic on CPU#1, agetty/2608

the patch below fixes this. There's another incarnation of the bug that 
i bisected today, a spontaneous reboot crash with certain configs:

| b70ac7718579b5cbf3bdd74fd01132d1c91596f4 is first bad commit
| commit b70ac7718579b5cbf3bdd74fd01132d1c91596f4
| Author: David Miller <davem@davemloft.net>
| Date:   Mon Oct 13 10:36:31 2008 +0100
|
|     serial: allow 8250 to be used on sparc

 # bad:  [e7f2f991] Merge phase #5 (misc) of git://git.kernel.org/pub/
 # good: [3fa8749e] Linux 2.6.27
 # good: [4dd9ec49] Merge git://git.kernel.org/pub/scm/linux/kernel/gi
 # good: [5c3c4d9b] Merge git://git.kernel.org/pub/scm/linux/kernel/gi
 # good: [1a2217a9] Merge git://git.kernel.org/pub/scm/linux/kernel/gi
 # good: [cf81978d] i386: convert hardware exception 15 to an interrup
 # good: [c00193f9] Merge branches 'oprofile-v2' and 'timers/hpet' int
 # bad:  [8f520021] tty: Termios locking - sort out real_tty confusion
 # good: [f1ddfd95] ip2: init/deinit cleanup
 # bad:  [b70ac771] serial: allow 8250 to be used on sparc
 # good: [9bde10a4] serial-make-uart_ports-ioport-unsigned-long-fix
 # good: [43b11d33] ftdi: A few errors are err() that should be debug 
 # good: [b5d674ab] 8250: remove a few inlines of dubious value

( but it's the same basic problem: we lost the lock init sequence when a
  patch was removed from the middle. )

	Ingo

----------------->
>From b15be1e63d0df3a1b4a25e7a28cfca9f93690884 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Tue, 14 Oct 2008 12:14:17 +0200
Subject: [PATCH] serial: fix serial port lock init

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/serial/8250.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index d4104a3..d3ca7d3 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -2969,6 +2969,9 @@ static int __init serial8250_init(void)
 		"%d ports, IRQ sharing %sabled\n", nr_uarts,
 		share_irqs ? "en" : "dis");
 
+	for (i = 0; i < NR_IRQS; i++)
+		spin_lock_init(&irq_lists[i].lock);
+
 #ifdef CONFIG_SPARC
 	ret = sunserial_register_minors(&serial8250_reg, UART_NR);
 #else


  reply	other threads:[~2008-10-14 10:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-13 22:05 [2.6.27-git-a447c093244] BUG: spinlock bad magic on CPU#0, setserial/3527 Rafael J. Wysocki
2008-10-13 22:50 ` Alan Cox
2008-10-14  6:55   ` Ingo Molnar
2008-10-14 10:22     ` Ingo Molnar [this message]
2008-10-14 11:40       ` [PATCH] serial: fix serial port lock init Kamalesh Babulal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081014102253.GA13503@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dtor@insightbb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox