* [PATCH] 8250: Fix lock warning
2008-10-14 10:28 [PATCH] Series short description Alan Cox
@ 2008-10-14 10:28 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2008-10-14 10:28 UTC (permalink / raw)
To: torvalds, linux-kernel
From: Alan Cox <alan@redhat.com>
Splitting the 8250 code back up to avoid a clash with the NR_IRQS removal
patch introduced a last minute bug. Put back the additional needed lines
for the old lock init
---
drivers/serial/8250.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index d4104a3..d3ca7d3 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -2969,6 +2969,9 @@ static int __init serial8250_init(void)
"%d ports, IRQ sharing %sabled\n", nr_uarts,
share_irqs ? "en" : "dis");
+ for (i = 0; i < NR_IRQS; i++)
+ spin_lock_init(&irq_lists[i].lock);
+
#ifdef CONFIG_SPARC
ret = sunserial_register_minors(&serial8250_reg, UART_NR);
#else
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] 8250: Fix lock warning
@ 2008-10-14 10:29 Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2008-10-14 10:29 UTC (permalink / raw)
To: torvalds, linux-kernel
(Resend with signed off by)
From: Alan Cox <alan@redhat.com>
Splitting the 8250 code back up to avoid a clash with the NR_IRQS removal
patch introduced a last minute bug. Put back the additional needed lines
for the old lock init
Signed-off-by: Alan Cox <alan@redhat.com>
---
drivers/serial/8250.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index d4104a3..d3ca7d3 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -2969,6 +2969,9 @@ static int __init serial8250_init(void)
"%d ports, IRQ sharing %sabled\n", nr_uarts,
share_irqs ? "en" : "dis");
+ for (i = 0; i < NR_IRQS; i++)
+ spin_lock_init(&irq_lists[i].lock);
+
#ifdef CONFIG_SPARC
ret = sunserial_register_minors(&serial8250_reg, UART_NR);
#else
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-14 10:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-14 10:29 [PATCH] 8250: Fix lock warning Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2008-10-14 10:28 [PATCH] Series short description Alan Cox
2008-10-14 10:28 ` [PATCH] 8250: Fix lock warning Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox