From: Andi Kleen <andi@firstfloor.org>
To: Robert Richter <robert.richter@amd.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org,
oprofile-list@lists.sourceforge.net, Ingo Molnar <mingo@elte.hu>
Subject: Re: Please pull arch perfmon update
Date: Tue, 14 Oct 2008 16:15:07 +0200 [thread overview]
Message-ID: <20081014141507.GQ12131@one.firstfloor.org> (raw)
In-Reply-To: <20081014140549.GG23557@erda.amd.com>
On Tue, Oct 14, 2008 at 04:05:50PM +0200, Robert Richter wrote:
> On 13.10.08 22:29:51, Andi Kleen wrote:
> > > I added a follow on patch (446223f) on branch arch-perfmon that
> >
> > I didn't do that intentionally because it's called too late.
> > The function really has to be called early, so that the fallback
> > works.
>
> The hook is in op_nmi_init() and directly called after
> arch_perfmon_init() and before init_sysfs(). Only
> register_cpu_notifier() and the setup of oprofile_operations are in
> between. This should work.
The problem is that arch perfmon init should only be called after
the other initialization function failed.
So you would need a chain of op_x86_model_spec for fallback.
It's simpler and cleaner to just write that out in explicit C.
-Andi
next prev parent reply other threads:[~2008-10-14 14:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 23:52 Please pull arch perfmon update Andi Kleen
2008-10-13 18:35 ` Robert Richter
2008-10-13 20:29 ` Andi Kleen
2008-10-14 14:05 ` Robert Richter
2008-10-14 14:15 ` Andi Kleen [this message]
2008-10-14 14:35 ` Robert Richter
2008-10-14 16:01 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014141507.GQ12131@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oprofile-list@lists.sourceforge.net \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox