public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Yu Zhao <yu.zhao@intel.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"jbarnes@virtuousgeek.org" <jbarnes@virtuousgeek.org>,
	"randy.dunlap@oracle.com" <randy.dunlap@oracle.com>,
	"grundler@parisc-linux.org" <grundler@parisc-linux.org>,
	"achiang@hp.com" <achiang@hp.com>,
	"matthew@wil.cx" <matthew@wil.cx>,
	"rdreier@cisco.com" <rdreier@cisco.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org" 
	<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH 6/8 v4] PCI: support the SR-IOV capability
Date: Tue, 14 Oct 2008 07:37:44 -0700	[thread overview]
Message-ID: <20081014143744.GA12251@kroah.com> (raw)
In-Reply-To: <20081014105928.GF1734@yzhao12-linux.sh.intel.com>

On Tue, Oct 14, 2008 at 06:59:28PM +0800, Yu Zhao wrote:
> +struct pci_iov {
> +	int cap;		/* capability position */
> +	int align;		/* page size used to map memory space */
> +	int is_enabled;		/* status of SR-IOV */
> +	int nentries;		/* number of sysfs entries used by PF driver */
> +	u16 totalvfs;		/* total VFs associated with the PF */
> +	u16 initialvfs;		/* initial VFs associated with the PF */
> +	u16 numvfs;		/* number of VFs available */
> +	u16 offset;		/* first VF Routing ID offset */
> +	u16 stride;		/* following VF stride */
> +	struct mutex mutex;	/* lock for SR-IOV */
> +	struct kobject kobj;	/* koject for IOV */

Why isn't this a real struct device?

That way you get all of the proper userspace notification and the like,
with kobjects, you do not.

thanks,

greg k-h

  parent reply	other threads:[~2008-10-14 14:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-14 10:34 [PATCH 0/8 v4] PCI: Linux kernel SR-IOV support Yu Zhao
2008-10-14 10:46 ` [PATCH 1/8 v4] PCI: define PCI resource names in an 'enum' Yu Zhao
2008-10-14 10:48 ` [PATCH 2/8 v4] PCI: export __pci_read_base Yu Zhao
2008-10-14 10:53 ` [PATCH 3/8 v4] PCI: export pci_alloc_child_bus Yu Zhao
2008-10-14 10:55 ` [PATCH 4/8 v4] PCI: add a wrapper for resource_alignment Yu Zhao
2008-10-14 10:57 ` [PATCH 5/8 v4] PCI: add a new function to map BAR offset Yu Zhao
2008-10-14 10:59 ` [PATCH 6/8 v4] PCI: support the SR-IOV capability Yu Zhao
2008-10-14 12:30   ` Matthew Wilcox
2008-10-15  2:04     ` Zhao, Yu
2008-10-14 14:37   ` Greg KH [this message]
2008-10-14 11:00 ` [PATCH 7/8 v4] PCI: reserve bus range for the SR-IOV device Yu Zhao
2008-10-14 11:01 ` [PATCH 8/8 v4] PCI: document the changes Yu Zhao
2008-10-17 22:54   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081014143744.GA12251@kroah.com \
    --to=greg@kroah.com \
    --cc=achiang@hp.com \
    --cc=grundler@parisc-linux.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=randy.dunlap@oracle.com \
    --cc=rdreier@cisco.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=yu.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox