From: Robert Richter <robert.richter@amd.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org,
oprofile-list@lists.sourceforge.net, Ingo Molnar <mingo@elte.hu>
Subject: Re: Please pull arch perfmon update
Date: Tue, 14 Oct 2008 18:01:48 +0200 [thread overview]
Message-ID: <20081014160148.GA1029@erda.amd.com> (raw)
In-Reply-To: <48F3AFBF.3040201@firstfloor.org>
On 13.10.08 22:29:51, Andi Kleen wrote:
> > There is one question to patch "oprofile: discover counters for op
> > ppro too". arch_perfmon_setup_counters() is actually never called for
> > ppro, so there is no code that changes the numbers in
> > op_ppro_spec. The patch as it is has no effect (except then loading
> > additional module code).
>
> Ah true, i must have deleted one hunk too much while refactoring.
> It's ok to drop this patch for now.
I sent it upstream anyway, please send an additional patch that fixes
this.
Thanks,
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com
prev parent reply other threads:[~2008-10-14 16:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 23:52 Please pull arch perfmon update Andi Kleen
2008-10-13 18:35 ` Robert Richter
2008-10-13 20:29 ` Andi Kleen
2008-10-14 14:05 ` Robert Richter
2008-10-14 14:15 ` Andi Kleen
2008-10-14 14:35 ` Robert Richter
2008-10-14 16:01 ` Robert Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014160148.GA1029@erda.amd.com \
--to=robert.richter@amd.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oprofile-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox