public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH tip/tracing/markers] markers: let marker_table be close to its comments
Date: Wed, 15 Oct 2008 09:44:46 -0400	[thread overview]
Message-ID: <20081015134446.GB29281@Krystal> (raw)
In-Reply-To: <48F5942F.4080400@cn.fujitsu.com>

* Lai Jiangshan (laijs@cn.fujitsu.com) wrote:
> 
> marker_table is defined far from its comments, this fix make
> cleanup for it.
> 

Good idea! Thanks.

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>


> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/kernel/marker.c b/kernel/marker.c
> index e9c6b2b..e49a9c5 100644
> --- a/kernel/marker.c
> +++ b/kernel/marker.c
> @@ -43,6 +43,7 @@ static DEFINE_MUTEX(markers_mutex);
>   */
>  #define MARKER_HASH_BITS 6
>  #define MARKER_TABLE_SIZE (1 << MARKER_HASH_BITS)
> +static struct hlist_head marker_table[MARKER_TABLE_SIZE];
>  
>  /*
>   * Note about RCU :
> @@ -67,8 +68,6 @@ struct marker_entry {
>  	char name[0];	/* Contains name'\0'format'\0' */
>  };
>  
> -static struct hlist_head marker_table[MARKER_TABLE_SIZE];
> -
>  /**
>   * __mark_empty_function - Empty probe callback
>   * @probe_private: probe private data
> 
> 
> 
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

  reply	other threads:[~2008-10-15 13:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-15  6:56 [PATCH tip/tracing/markers] markers: let marker_table be close to its comments Lai Jiangshan
2008-10-15 13:44 ` Mathieu Desnoyers [this message]
2008-10-20 13:31   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081015134446.GB29281@Krystal \
    --to=mathieu.desnoyers@polymtl.ca \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox