Re: [PATCH tip/tracing/markers] markers: remove exported symbol marker_probe_cb_noarg()

[Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>]

* Lai Jiangshan (laijs@cn.fujitsu.com) wrote:
> 
> marker_probe_cb_noarg() should not be seen by outer code.
> this patch remove it.
> 

Yep, good idea. Thanks!

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>

> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/include/linux/marker.h b/include/linux/marker.h
> index 38e32e7..4aca94a 100644
> --- a/include/linux/marker.h
> +++ b/include/linux/marker.h
> @@ -137,8 +137,6 @@ extern marker_probe_func __mark_empty_function;
>  
>  extern void marker_probe_cb(const struct marker *mdata,
>  	void *call_private, ...);
> -extern void marker_probe_cb_noarg(const struct marker *mdata,
> -	void *call_private, ...);
>  
>  /*
>   * Connect a probe to a marker.
> diff --git a/kernel/marker.c b/kernel/marker.c
> index ef43c86..0f2a944 100644
> --- a/kernel/marker.c
> +++ b/kernel/marker.c
> @@ -157,7 +157,7 @@ EXPORT_SYMBOL_GPL(marker_probe_cb);
>   *
>   * Should be connected to markers "MARK_NOARGS".
>   */
> -void marker_probe_cb_noarg(const struct marker *mdata, void *call_private, ...)
> +static void marker_probe_cb_noarg(const struct marker *mdata, void *call_private, ...)
>  {
>  	va_list args;	/* not initialized */
>  	char ptype;
> @@ -197,7 +197,6 @@ void marker_probe_cb_noarg(const struct marker *mdata, void *call_private, ...)
>  	}
>  	rcu_read_unlock_sched();
>  }
> -EXPORT_SYMBOL_GPL(marker_probe_cb_noarg);
>  
>  static void free_old_closure(struct rcu_head *head)
>  {
> 
> 
> 
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68