From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
John Brown <john.brown3@hp.com>
Subject: Re: [PATCH] ACPI suspend: Blacklist HP xw4600 Workstation for old code ordering
Date: Wed, 15 Oct 2008 16:05:35 +0200 [thread overview]
Message-ID: <200810151605.35883.rjw@sisk.pl> (raw)
In-Reply-To: <20081015085809.GA1061@srcf.ucam.org>
On Wednesday, 15 of October 2008, Matthew Garrett wrote:
> On Tue, Oct 14, 2008 at 10:54:06PM +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > ACPI suspend: Blacklist HP xw4600 Workstation for old code ordering
> >
> > HP xw4600 Workstation is known to require the "old" (ie. compatible
> > with ACPI 1.0) suspend code ordering, so blacklist it for this
> > purpose.
>
> This doesn't seem to be scaling especially well. The xw4600 is a new
> machine, so if it needs the "old" code ordering then that's a strong
> indication that we're doing something wrong.
No, sorry.
> I think trying to work out what would be more useful than just adding it to
> a blacklist.
Well, machines that require the "old" ordering are simply broken, because
you just can't assume that specific devices are not in D3 before you
execute _PTS.
IOW, we aren't doing anything wrong and the BIOS is buggy.
Thanks,
Rafael
next prev parent reply other threads:[~2008-10-15 14:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 20:54 [PATCH] ACPI suspend: Blacklist HP xw4600 Workstation for old code ordering Rafael J. Wysocki
2008-10-15 8:58 ` Matthew Garrett
2008-10-15 14:05 ` Rafael J. Wysocki [this message]
2008-10-15 14:15 ` Matthew Garrett
2008-10-15 20:35 ` Brown, John M (WGBU R&D)
2008-10-15 21:49 ` Len Brown
2008-10-15 22:00 ` Rafael J. Wysocki
2008-10-16 17:01 ` Brown, John M (WGBU R&D)
2008-10-16 19:31 ` Len Brown
2008-10-15 21:20 ` Rafael J. Wysocki
2008-11-22 11:11 ` Carlos Corbacho
2008-11-22 12:56 ` Rafael J. Wysocki
2008-10-16 9:13 ` Pavel Machek
2008-10-16 9:12 ` Pavel Machek
[not found] <fa./6DR3VeG3JltQZvwctIdnZpBOO8@ifi.uio.no>
[not found] ` <fa.TMVI/3KJQDTBIWAfYmLw01GczF4@ifi.uio.no>
[not found] ` <fa./GCX/x0zwCB6BIEvtQehNpVDSVk@ifi.uio.no>
[not found] ` <fa.MkpTJy5Iw9ZR3PXWpugQeK5oN1o@ifi.uio.no>
2008-10-17 4:07 ` Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810151605.35883.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=john.brown3@hp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox