Re: trivial patches: Should we care about control reaches end of non-void function

Alan Cox
2008-10-15T22:26:36Z

> I see some functions in the kernel have added "return 0" after the
> BUG, presumably to silence these warnings. Would a patch to do this
> consistently, or is that too trivial even for trivial patches?

Probably better to mark BUG() properly for the compiler.

If you can get __attribute((__noreturn__)) on the end of the BUG function
somehow say

static inline void bug_off(void) __attribute((__noreturn__)) {};

and expanded that onto the end of the macro maybe it would shut up

Alan