public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frans Pop <elendil@planet.nl>
To: sfstudio@mail.ru
Cc: gorcunov@gmail.com, linux-kernel@vger.kernel.org,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: Re: Re: patch to 2.6.27 fix build rpm
Date: Wed, 15 Oct 2008 20:53:12 +0200	[thread overview]
Message-ID: <200810152053.13629.elendil@planet.nl> (raw)
In-Reply-To: <E1KqAJK-000KWz-00.sfstudio-mail-ru@f121.mail.ru>

Евгений Маначкин wrote:
>   echo 'mkdir -p $RPM_BUILD_ROOT/boot/efi $RPM_BUILD_ROOT/lib/modules'
>  +echo 'mkdir -p $RPM_BUILD_ROOT/boot/efi $RPM_BUILD_ROOT/lib/firmware'
>   echo "%else"
>   echo 'mkdir -p $RPM_BUILD_ROOT/boot $RPM_BUILD_ROOT/lib/modules'
>  +echo 'mkdir -p $RPM_BUILD_ROOT/boot $RPM_BUILD_ROOT/lib/firmware'

Is it really necessary to make the first directory twice in both cases?

I would suggest changing the patch to simply:
 echo 'mkdir -p $RPM_BUILD_ROOT/boot/efi $RPM_BUILD_ROOT/lib/modules'
+echo 'mkdir -p $RPM_BUILD_ROOT/lib/firmware'
 echo "%else"
 echo 'mkdir -p $RPM_BUILD_ROOT/boot $RPM_BUILD_ROOT/lib/modules'
+echo 'mkdir -p $RPM_BUILD_ROOT/lib/firmware'

Or even adding the creation of the firware dir to the original mkdirs.

Cheers,
FJP

  parent reply	other threads:[~2008-10-15 18:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-15 14:04 patch to 2.6.27 fix build rpm Евгений Маначкин
2008-10-15 15:35 ` Cyrill Gorcunov
2008-10-15 16:54   ` Евгений Маначкин
2008-10-15 17:24     ` Cyrill Gorcunov
2008-10-15 17:37       ` Евгений Маначкин
2008-10-15 17:46         ` [PATCH] " Alan Cox
2008-10-23 20:46           ` [stable] " Greg KH
2008-10-23 23:50             ` Randy Dunlap
2008-10-24  6:04               ` Sam Ravnborg
2008-10-15 17:47         ` Re: " Cyrill Gorcunov
2008-10-16  1:17           ` Ian Hilt
2008-10-15 18:53         ` Frans Pop [this message]
2008-10-15 19:08           ` Евгений Маначкин
2008-10-15 18:56         ` H. Peter Anvin
2008-10-15 17:36     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810152053.13629.elendil@planet.nl \
    --to=elendil@planet.nl \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gorcunov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfstudio@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox