* [Patch] kernel/configs.c: remove useless comments
@ 2008-10-16 16:04 Américo Wang
2008-10-16 23:20 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Américo Wang @ 2008-10-16 16:04 UTC (permalink / raw)
To: LKML; +Cc: Randy Dunlap, Andrew Morton
These comments are useless, remove them.
Signed-off-by: WANG Cong <wangcong@zeuux.org>
Cc: Randy Dunlap <rdunlap@xenotime.net>
---
diff --git a/kernel/configs.c b/kernel/configs.c
index 4c34521..abaee68 100644
--- a/kernel/configs.c
+++ b/kernel/configs.c
@@ -54,9 +54,6 @@
#ifdef CONFIG_IKCONFIG_PROC
-/**************************************************/
-/* globals and useful constants */
-
static ssize_t
ikconfig_read_current(struct file *file, char __user *buf,
size_t len, loff_t * offset)
@@ -71,9 +68,6 @@ static const struct file_operations ikconfig_file_ops = {
.read = ikconfig_read_current,
};
-/***************************************************/
-/* ikconfig_init: start up everything we need to */
-
static int __init ikconfig_init(void)
{
struct proc_dir_entry *entry;
@@ -89,9 +83,6 @@ static int __init ikconfig_init(void)
return 0;
}
-/***************************************************/
-/* ikconfig_cleanup: clean up our mess */
-
static void __exit ikconfig_cleanup(void)
{
remove_proc_entry("config.gz", NULL);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] kernel/configs.c: remove useless comments
2008-10-16 16:04 [Patch] kernel/configs.c: remove useless comments Américo Wang
@ 2008-10-16 23:20 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2008-10-16 23:20 UTC (permalink / raw)
To: Américo Wang; +Cc: linux-kernel, rdunlap
On Thu, 16 Oct 2008 17:04:54 +0100
Am__rico Wang <xiyou.wangcong@gmail.com> wrote:
> These comments are useless, remove them.
Thanks for doing this, but...
We have about 10000000000000 useless comments in the kernel. I
wouldn't want to clean them up with 10000000000000/3 tiny patches. It
would be more practical if we were to merge larger patches with names like
"remove all useless comments in kernel/*.c".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-16 23:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-16 16:04 [Patch] kernel/configs.c: remove useless comments Américo Wang
2008-10-16 23:20 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox