From: "Frank Ch. Eigler" <fche@redhat.com>
To: Mathieu Desnoyers <compudj@krystal.dyndns.org>
Cc: Jason Baron <jbaron@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, fweisbec@gmail.com,
edwintorok@gmail.com, mingo@elte.hu,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: tracepoints for kernel/mutex.c
Date: Fri, 17 Oct 2008 12:58:45 -0400 [thread overview]
Message-ID: <20081017165845.GB12352@redhat.com> (raw)
In-Reply-To: <20081017164352.GF5696@Krystal>
Hi -
On Fri, Oct 17, 2008 at 12:43:52PM -0400, Mathieu Desnoyers wrote:
> [...]
> > > _IFF_ you want to place tracepoints, get them in the same place as the
> > > lock-dep/stat hooks, that way you get all the locks, not only mutexes.
> >
> > makes sense. So we could layer lock-dep/stat on top of tracepoints? That
> > would potentially also make lock-dep/stat more dynamic.
> Guys, please, let's focus on the infrastructure to manage trace data
> (timestamping, buffering, event ID, event type management) before
> going any further in the instrumentation direction.
Any trace data management widget design that precludes connection to
an event source as simple as tracepoints or markers is going to be a
disappointment.
> Otherwise we will end up adding instrumentation in the Linux kernel
> without any in-kernel user [...]
Connecting markers to /proc style text files has been demonstrated in
less than a hundred lines of code.
Plus, Jason's note clearly referred to another in-kernel use of this
instrumentation: the possibility of connecting lockdep via generic
tracepoints in the lock-related code rather than special-purpose
hooks. One benefit could be being able to compile in lockdep and/or
lockstat by default (activating it via a boot option). The other
would be of course the concurrent/alternative of the instrumentation
for performance-related purposes.
- FChE
next prev parent reply other threads:[~2008-10-17 16:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-16 21:04 tracepoints for kernel/mutex.c Jason Baron
2008-10-16 21:34 ` Peter Zijlstra
2008-10-16 22:14 ` Thomas Gleixner
2008-10-17 5:09 ` KOSAKI Motohiro
2008-10-17 8:15 ` Peter Zijlstra
2008-10-17 8:22 ` KOSAKI Motohiro
2008-10-17 16:36 ` Mathieu Desnoyers
2008-10-17 14:48 ` Jason Baron
2008-10-17 16:43 ` Mathieu Desnoyers
2008-10-17 16:58 ` Frank Ch. Eigler [this message]
2008-10-17 16:48 ` Peter Zijlstra
2008-10-17 16:54 ` Mathieu Desnoyers
2008-10-16 22:10 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081017165845.GB12352@redhat.com \
--to=fche@redhat.com \
--cc=compudj@krystal.dyndns.org \
--cc=edwintorok@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox