Re: [PATCH v3] Add SPI over GPIO driver

Magnus Damm
2008-10-20T02:44:30Z

On Sun, Oct 19, 2008 at 5:54 AM, David Brownell <david-b@pacbell.net> wrote:
> On Saturday 18 October 2008, Piotr Skamruk wrote:
>> 2008/10/18 Michael Buesch <mb@bu3sch.de>:
>> > On Saturday 18 October 2008 06:36:31 Andrew Morton wrote:
>> >> This patch has some "issues" a month or so ago. Current status is that
>> >
>> > yeah, upstream maintainers don't like these patches.
>> > Please drop this one and the "gpiommc" patch now.
>> >
>> As i remember - David stands that these patches (or even
>> functionality) are not usable for him, so he don't want to see them in
>> mainstream kernel sources. It's his choice, he is maintainer of this
>> subsystem.
>
> That patch is very limited, and wrong in several respects.
>
> I fully support the idea of SPI over GPIO. It's just that
> particular patch which is problematic.

Ok, let's fix those issues then!

>> You have this on openwrt svn, I have it on my dev gittree - and as You
>> can see on Magnus example - anybody interested can google for it.
>> Maybe if there will be next few peoples - David will change his
>> opinion on this subject...
>
> I'm sanity testing a refresh of the *original* late-2006
> SPI-over-GPIO driver. It's actually usable as a drop-in
> replacement for a "native" driver.

The Openwrt driver by Michael Buesch works just fine for me, but if
you prefer to switch driver that's of course ok too.

> Unfortunately I goofed and pulled down the current GIT tree
> and found lots of unrelated breakage (non-SPI) that's keept
> that sanity test from proceeding apace. And the board on
> which it's most recently been used is currently broken.
> I may just send that patch out soon, as an FYI...

Please CC me and I'll test it on some SuperH boards. Thanks!

/ magnus