Re: [PATCH v3] Add SPI over GPIO driver

Michael Buesch
2008-10-17T11:19:20Z

On Friday 17 October 2008 11:52:32 Magnus Damm wrote:
> [removed closed openwrt-devel list]
>
> On Fri, Oct 17, 2008 at 5:52 PM, Michael Buesch <mb@bu3sch.de> wrote:
> > On Friday 17 October 2008 05:14:26 Magnus Damm wrote:
> >> On Mon, Jul 21, 2008 at 4:46 AM, Michael Buesch <mb@bu3sch.de> wrote:
> >> > This adds a driver that lets you drive an SPI bus over
> >> > generic GPIO pins.
> >> >
> >> > Signed-off-by: Michael Buesch <mb@bu3sch.de>
> >>
> >> Very useful. Fits my shiny new GPIO implementation for SuperH like a glove.
> >>
> >> Michael, as you know, I have some SuperH board code that makes use of
> >> this driver. Are there any outstanding issues with this driver that I
> >> can help resolving?
> >
> > bool cs_activelow should probably be removed from struct spi_gpio_platform_data.
> >
> > I think cs always is activelow, so we can simply hardcode this in spi_gpio_chipselect()
>
> Really? There _must_ be chips out there that want active high CS!
> I'd rather keep the activelow option or maybe turn in into activehigh instead.

Ok, I dunno. I never saw one. All of my SPI stuff is activelow.
So well, let's keep it.

> > If you want to do this, please feel free to do so.
> > I currently don't have the time for this.
> > The rest of the driver is fine with me.
>
> Ok, thank you.
>
> David or Andrew, any change of getting this merged as-is somehow? Thanks!

Yes, please merge it.

--
Greetings Michael.