From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: Mark Jackson <mpfj@mimc.co.uk>
Cc: dbrownell@users.sourceforge.net,
lkml <linux-kernel@vger.kernel.org>,
rtc-linux@googlegroups.com,
spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH v2] Add Dallas DS1390 RTC chip
Date: Mon, 20 Oct 2008 11:46:07 +0200 [thread overview]
Message-ID: <20081020114607.1b0299cb@i1501.lan.towertech.it> (raw)
In-Reply-To: <48FC442E.9070206@mimc.co.uk>
On Mon, 20 Oct 2008 09:41:18 +0100
Mark Jackson <mpfj@mimc.co.uk> wrote:
> +struct ds1390 {
> + struct rtc_device *rtc;
> + u8 buf[9]; /* cmd + 8 registers */
> + u8 tx_buf[2];
> + u8 rx_buf[2];
> +};
> +
don't we still have too many buffers?
the use of bin2bcd an bcd2bin (lowercase) would also be appreciated.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
next prev parent reply other threads:[~2008-10-20 9:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 8:41 [PATCH v2] Add Dallas DS1390 RTC chip Mark Jackson
2008-10-20 9:46 ` Alessandro Zummo [this message]
2008-10-20 11:44 ` Mark Jackson
2008-10-20 16:59 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081020114607.1b0299cb@i1501.lan.towertech.it \
--to=alessandro.zummo@towertech.it \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mpfj@mimc.co.uk \
--cc=rtc-linux@googlegroups.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox