From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Bastian Blank <bastian@waldi.eu.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [patch 2/2] introduce vdso on s390
Date: Mon, 20 Oct 2008 15:06:50 +0200 [thread overview]
Message-ID: <20081020130650.GA4465@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20081017153436.GA17116@wavehammer.waldi.eu.org>
On Fri, Oct 17, 2008 at 05:34:36PM +0200, Bastian Blank wrote:
> On Wed, Oct 15, 2008 at 07:45:08PM +0200, Martin Schwidefsky wrote:
> > +void update_vsyscall(struct timespec *wall_time, struct clocksource *clock)
> > +{
> > + if (clock != &clocksource_tod)
> > + return;
> > +
> > + /* Make userspace gettimeofday spin until we're done. */
> > + ++vdso_data->tb_update_count;
> > + smp_mb();
> > + vdso_data->xtime_tod_stamp = clock->cycle_last;
> > + vdso_data->xtime_clock_sec = xtime.tv_sec;
> > + vdso_data->xtime_clock_nsec = xtime.tv_nsec;
> > + vdso_data->wtom_clock_sec = wall_to_monotonic.tv_sec;
> > + vdso_data->wtom_clock_nsec = wall_to_monotonic.tv_nsec;
> > + smp_wmb();
>
> Different barriers?
Doesn't matter. They are all the same anyway on s390. But I changed it to
smp_wmb instead.
> > + ++(vdso_data->tb_update_count);
>
> Why ++(...)?
Removed the braces.
prev parent reply other threads:[~2008-10-20 13:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 17:45 [patch 0/2] vdso support for s390 Martin Schwidefsky
2008-10-15 17:45 ` [patch 1/2] arch_setup_additional_pages arguments Martin Schwidefsky
2008-10-15 17:45 ` [patch 2/2] introduce vdso on s390 Martin Schwidefsky
2008-10-17 15:34 ` Bastian Blank
2008-10-20 13:06 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081020130650.GA4465@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=bastian@waldi.eu.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox