From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1753461AbYJTNHH@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753461AbYJTNHH (ORCPT <rfc822;w@1wt.eu>);
	Mon, 20 Oct 2008 09:07:07 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752200AbYJTNGy
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 20 Oct 2008 09:06:54 -0400
Received: from mtagate1.uk.ibm.com ([194.196.100.161]:53620 "EHLO
	mtagate1.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751673AbYJTNGx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 20 Oct 2008 09:06:53 -0400
Date: Mon, 20 Oct 2008 15:06:50 +0200
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Bastian Blank <bastian@waldi.eu.org>,
       Martin Schwidefsky <schwidefsky@de.ibm.com>,
       linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
       linux-arch@vger.kernel.org
Subject: Re: [patch 2/2] introduce vdso on s390
Message-ID: <20081020130650.GA4465@osiris.boeblingen.de.ibm.com>
References: <20081015174506.107691579@de.ibm.com> <20081015175305.332585239@de.ibm.com> <20081017153436.GA17116@wavehammer.waldi.eu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081017153436.GA17116@wavehammer.waldi.eu.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 17, 2008 at 05:34:36PM +0200, Bastian Blank wrote:
> On Wed, Oct 15, 2008 at 07:45:08PM +0200, Martin Schwidefsky wrote:
> > +void update_vsyscall(struct timespec *wall_time, struct clocksource *clock)
> > +{
> > +	if (clock != &clocksource_tod)
> > +		return;
> > +
> > +	/* Make userspace gettimeofday spin until we're done. */
> > +	++vdso_data->tb_update_count;
> > +	smp_mb();
> > +	vdso_data->xtime_tod_stamp = clock->cycle_last;
> > +	vdso_data->xtime_clock_sec = xtime.tv_sec;
> > +	vdso_data->xtime_clock_nsec = xtime.tv_nsec;
> > +	vdso_data->wtom_clock_sec = wall_to_monotonic.tv_sec;
> > +	vdso_data->wtom_clock_nsec = wall_to_monotonic.tv_nsec;
> > +	smp_wmb();
> 
> Different barriers?

Doesn't matter. They are all the same anyway on s390. But I changed it to
smp_wmb instead.

> > +	++(vdso_data->tb_update_count);
>
> Why ++(...)?

Removed the braces.