From: Ingo Molnar <mingo@elte.hu>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH tip/tracing/markers] markers: simplify marker_set_format()
Date: Mon, 20 Oct 2008 15:30:03 +0200 [thread overview]
Message-ID: <20081020133003.GA27656@elte.hu> (raw)
In-Reply-To: <20081015134416.GA29281@Krystal>
* Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:
> * Lai Jiangshan (laijs@cn.fujitsu.com) wrote:
> >
> > current marker_set_format() is complex this patch simplify it,
> > and decrease the overhead of marker_update_probes().
> >
>
> Yep, I think I did put the format string after the name \0, which was
> rather tricky. I agree that such change makes the code more readable at
> the expense of doing 2 allocations per marker rather than one, but
> readability might be a good thing here.
>
> Thanks !
>
> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
applied to tip/tracing/markers, thanks!
Ingo
prev parent reply other threads:[~2008-10-20 13:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 6:56 [PATCH tip/tracing/markers] markers: simplify marker_set_format() Lai Jiangshan
2008-10-15 13:44 ` Mathieu Desnoyers
2008-10-20 8:26 ` Lai Jiangshan
2008-10-20 15:43 ` Mathieu Desnoyers
2008-10-20 8:48 ` Lai Jiangshan
2008-10-20 13:30 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081020133003.GA27656@elte.hu \
--to=mingo@elte.hu \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox