* [PATCH tip/tracing/markers] markers: let marker_table be close to its comments
@ 2008-10-15 6:56 Lai Jiangshan
2008-10-15 13:44 ` Mathieu Desnoyers
0 siblings, 1 reply; 3+ messages in thread
From: Lai Jiangshan @ 2008-10-15 6:56 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Mathieu Desnoyers, Linux Kernel Mailing List
marker_table is defined far from its comments, this fix make
cleanup for it.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
diff --git a/kernel/marker.c b/kernel/marker.c
index e9c6b2b..e49a9c5 100644
--- a/kernel/marker.c
+++ b/kernel/marker.c
@@ -43,6 +43,7 @@ static DEFINE_MUTEX(markers_mutex);
*/
#define MARKER_HASH_BITS 6
#define MARKER_TABLE_SIZE (1 << MARKER_HASH_BITS)
+static struct hlist_head marker_table[MARKER_TABLE_SIZE];
/*
* Note about RCU :
@@ -67,8 +68,6 @@ struct marker_entry {
char name[0]; /* Contains name'\0'format'\0' */
};
-static struct hlist_head marker_table[MARKER_TABLE_SIZE];
-
/**
* __mark_empty_function - Empty probe callback
* @probe_private: probe private data
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH tip/tracing/markers] markers: let marker_table be close to its comments
2008-10-15 6:56 [PATCH tip/tracing/markers] markers: let marker_table be close to its comments Lai Jiangshan
@ 2008-10-15 13:44 ` Mathieu Desnoyers
2008-10-20 13:31 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Desnoyers @ 2008-10-15 13:44 UTC (permalink / raw)
To: Lai Jiangshan; +Cc: Ingo Molnar, Linux Kernel Mailing List
* Lai Jiangshan (laijs@cn.fujitsu.com) wrote:
>
> marker_table is defined far from its comments, this fix make
> cleanup for it.
>
Good idea! Thanks.
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/kernel/marker.c b/kernel/marker.c
> index e9c6b2b..e49a9c5 100644
> --- a/kernel/marker.c
> +++ b/kernel/marker.c
> @@ -43,6 +43,7 @@ static DEFINE_MUTEX(markers_mutex);
> */
> #define MARKER_HASH_BITS 6
> #define MARKER_TABLE_SIZE (1 << MARKER_HASH_BITS)
> +static struct hlist_head marker_table[MARKER_TABLE_SIZE];
>
> /*
> * Note about RCU :
> @@ -67,8 +68,6 @@ struct marker_entry {
> char name[0]; /* Contains name'\0'format'\0' */
> };
>
> -static struct hlist_head marker_table[MARKER_TABLE_SIZE];
> -
> /**
> * __mark_empty_function - Empty probe callback
> * @probe_private: probe private data
>
>
>
>
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH tip/tracing/markers] markers: let marker_table be close to its comments
2008-10-15 13:44 ` Mathieu Desnoyers
@ 2008-10-20 13:31 ` Ingo Molnar
0 siblings, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-10-20 13:31 UTC (permalink / raw)
To: Mathieu Desnoyers; +Cc: Lai Jiangshan, Linux Kernel Mailing List
* Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:
> * Lai Jiangshan (laijs@cn.fujitsu.com) wrote:
> >
> > marker_table is defined far from its comments, this fix make
> > cleanup for it.
> >
>
> Good idea! Thanks.
>
> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
applied to tip/tracing/markers, thanks!
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-20 13:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-15 6:56 [PATCH tip/tracing/markers] markers: let marker_table be close to its comments Lai Jiangshan
2008-10-15 13:44 ` Mathieu Desnoyers
2008-10-20 13:31 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox