From: Ingo Molnar <mingo@elte.hu>
To: Jike Song <albcamus@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: questions about rd{msr|tsc|pmc} instruction with x86-64
Date: Mon, 20 Oct 2008 15:47:40 +0200 [thread overview]
Message-ID: <20081020134740.GA8007@elte.hu> (raw)
In-Reply-To: <48F821B3.2060300@gmail.com>
* Jike Song <albcamus@gmail.com> wrote:
> H. Peter Anvin wrote:
>> Jike Song wrote:
>> > Thanks, Peter! So I misunderstood the gcc constraint 'A' for x86-64,
>> > but seems the comment "while x86_64 returns at rax" still wrong,
>> > should this be fixed?
>>
>> Yes, feel free to submit a patch.
>>
>> -hpa
> Here you go... CC trivial@kernel.org as well.
>
> From 6eed2948d41f959dc113eb3ff30927bcacf34d08 Mon Sep 17 00:00:00 2001
> From: Jike Song <albcamus@gmail.com>
> Date: Fri, 17 Oct 2008 10:51:13 +0800
> Subject: [PATCH] x86: correct wrong comment
>
> The rdmsr instruction(et al) for i386 and x86-64 are semantically same.
> The only difference is how gcc interpret constraint "A" for these targets.
>
> Signed-off-by: Jike Song <albcamus@gmail.com>
> ---
> include/asm-x86/msr.h | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
applied to tip/x86/cleanups, thanks!
Ingo
prev parent reply other threads:[~2008-10-20 13:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-16 6:30 questions about rd{msr|tsc|pmc} instruction with x86-64 Jike Song
2008-10-16 6:39 ` H. Peter Anvin
2008-10-16 16:31 ` Jike Song
[not found] ` <48F76FA3.1000602@zytor.com>
2008-10-17 5:25 ` Jike Song
2008-10-20 13:47 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081020134740.GA8007@elte.hu \
--to=mingo@elte.hu \
--cc=albcamus@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox