Re: questions about rd{msr|tsc|pmc} instruction with x86-64

Ingo Molnar
2008-10-20T13:48:15Z

* Jike Song <albcamus@gmail.com> wrote:

> H. Peter Anvin wrote:
>> Jike Song wrote:
>> > Thanks, Peter! So I misunderstood the gcc constraint 'A' for x86-64,
>> > but seems the comment "while x86_64 returns at rax" still wrong,
>> > should this be fixed?
>>
>> Yes, feel free to submit a patch.
>>
>> -hpa
> Here you go... CC trivial@kernel.org as well.
>
> From 6eed2948d41f959dc113eb3ff30927bcacf34d08 Mon Sep 17 00:00:00 2001
> From: Jike Song <albcamus@gmail.com>
> Date: Fri, 17 Oct 2008 10:51:13 +0800
> Subject: [PATCH] x86: correct wrong comment
>
> The rdmsr instruction(et al) for i386 and x86-64 are semantically same.
> The only difference is how gcc interpret constraint "A" for these targets.
>
> Signed-off-by: Jike Song <albcamus@gmail.com>
> ---
> include/asm-x86/msr.h | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)

applied to tip/x86/cleanups, thanks!

Ingo