public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Chiang <achiang@hp.com>
To: ebiederm@xmission.com, oomichi@mxs.nes.nec.co.jp,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	tony.luck@intel.com
Subject: Re: [PATCH] declare vmlist to fix ia64 build breakage in kexec core
Date: Mon, 20 Oct 2008 17:52:58 -0600	[thread overview]
Message-ID: <20081020235258.GH15771@ldl.fc.hp.com> (raw)
In-Reply-To: <20081020233438.GG15771@ldl.fc.hp.com>

Oh whoops, I see that Tony Luck already sent a patch for this
directly to Linus.

[Sorry for the noise, but I didn't realize this until I decided
to browse through my lkml folder, as Tony's patch hasn't been
pushed out yet.]

/ac

* Alex Chiang <achiang@hp.com>:
> Commit acd99dbf54020f5c80b9aa2f2ea86f43cb285b02 (kdump: add
> vmlist.addr to vmcoreinfo for x86 vmalloc translation) broke the
> ia64 build in this fashion:
> 
> kernel/kexec.c: In function `crash_save_vmcoreinfo_init':
> kernel/kexec.c:1374: error: `vmlist' undeclared (first use in this function)
> kernel/kexec.c:1374: error: (Each undeclared identifier is reported only once
> kernel/kexec.c:1374: error: for each function it appears in.)
> kernel/kexec.c:1410: error: dereferencing pointer to incomplete type
> make[1]: *** [kernel/kexec.o] Error 1
> 
> Adding the proper include fixes the build.
> 
> Signed-off-by: Alex Chiang <achiang@hp.com>
> ---
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 777ac45..ac0fde7 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -30,6 +30,7 @@
>  #include <linux/pm.h>
>  #include <linux/cpu.h>
>  #include <linux/console.h>
> +#include <linux/vmalloc.h>
>  
>  #include <asm/page.h>
>  #include <asm/uaccess.h>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

  reply	other threads:[~2008-10-20 23:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-20 23:34 [PATCH] declare vmlist to fix ia64 build breakage in kexec core Alex Chiang
2008-10-20 23:52 ` Alex Chiang [this message]
2008-10-21  0:31   ` Ken'ichi Ohmichi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081020235258.GH15771@ldl.fc.hp.com \
    --to=achiang@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oomichi@mxs.nes.nec.co.jp \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox