Re: [PATCH 2.6.27] x86: memtest fix use of reserve_early()

[Daniele Calore <orkaan@orkaan.org>]

Hi Ingo and all,

Is there any news about this patch ?
AFAIK without this fix memtest is unusefull.
But if I'm wrong, apologise for the noise.

Bye,

Daniele
--

On Mon, 13 Oct 2008 10:34:12 +0200
Daniele Calore <orkaan@orkaan.org> wrote:

> Hi all,
>     
> Wrong usage of 2nd parameter in reserve_early call.
> 66/75: reserve_early(start_bad, last_bad - start_bad, "BAD RAM");
>                                 ^^^^^^^^^^^^^^^^^^^^
>     
> The correct way is to use 'end' address and not 'size'.
> As a bonus a fix to the printk format.
> 
> Signed-off-by: Daniele Calore <orkaan@orkaan.org>
>     
> ---
> diff --git a/arch/x86/mm/memtest.c b/arch/x86/mm/memtest.c
> index 672e17f..9cab18b 100644
> --- a/arch/x86/mm/memtest.c
> +++ b/arch/x86/mm/memtest.c
> @@ -61,9 +61,9 @@ static void __init memtest(unsigned long
> start_phys, unsigned long size, last_bad += incr;
>  			} else {
>  				if (start_bad) {
> -					printk(KERN_CONT "\n  %010lx
> bad mem addr %010lx - %010lx reserved",
> +					printk(KERN_CONT "\n  %016lx
> bad mem addr %010lx - %010lx reserved", val, start_bad, last_bad +
> incr);
> -					reserve_early(start_bad,
> last_bad - start_bad, "BAD RAM");
> +					reserve_early(start_bad,
> last_bad + incr, "BAD RAM"); }
>  				start_bad = last_bad =
> start_phys_aligned; }
> @@ -72,9 +72,8 @@ static void __init memtest(unsigned long
> start_phys, unsigned long size, if (start_bad) {
>  		printk(KERN_CONT "\n  %016lx bad mem addr %010lx -
> %010lx reserved", val, start_bad, last_bad + incr);
> -		reserve_early(start_bad, last_bad - start_bad, "BAD
> RAM");
> +		reserve_early(start_bad, last_bad + incr, "BAD RAM");
>  	}
> -
>  }
>  
>  /* default is disabled */