From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] include io.h in pci.h to avoid pci_ioremap build errors
Date: Tue, 21 Oct 2008 10:28:38 -0700 [thread overview]
Message-ID: <200810211028.38630.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <200810211007.14378.jbarnes@virtuousgeek.org>
On Tuesday, October 21, 2008 10:07 am Jesse Barnes wrote:
> Ingo pointed out that the m32r build was broken by pci_ioremap. It looks
> like some files include pci.h w/o including io.h. The latter defines
> ioremap_* if present, so it makes sense to include it in pci.h now that we
> have pci_ioremap there.
>
> I'll queue this up in my tree for the next pull request, but affected users
> can apply this patch in the meantime.
>
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 085187b..3e2f1d3 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -18,6 +18,7 @@
> #define LINUX_PCI_H
>
> #include <linux/pci_regs.h> /* The pci register defines */
> +#include <asm/io.h>
>
> /*
> * The PCI interface treats multi-function devices as independent
The fix I applied to my tree uses linux/io.h instead, which is probably more
correct (thanks David!).
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2008-10-21 17:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 17:07 [PATCH] include io.h in pci.h to avoid pci_ioremap build errors Jesse Barnes
2008-10-21 17:28 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810211028.38630.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox